| Message ID | 20200325031433.28223-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] kconfig: remove unused variable in qconf.cc | expand |
On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote: > If this file were compiled with -Wall, the following warning would be > reported: > > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] > int i; > ^ > > The commit prepares to turn on -Wall for C++ host programs. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > > scripts/kconfig/qconf.cc | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > index 82773cc35d35..50a5245d87bb 100644 > --- a/scripts/kconfig/qconf.cc > +++ b/scripts/kconfig/qconf.cc > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), > rootEntry(0), headerPopup(0) > { > - int i; > - > setObjectName(name); > setSortingEnabled(false); > setRootIsDecorated(true); > -- > 2.17.1 >
On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote: > > On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote: > > If this file were compiled with -Wall, the following warning would be > > reported: > > > > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] > > int i; > > ^ > > > > The commit prepares to turn on -Wall for C++ host programs. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Reviewed-by: Kees Cook <keescook@chromium.org> > Applied to linux-kbuild. > -Kees > > > --- > > > > scripts/kconfig/qconf.cc | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc > > index 82773cc35d35..50a5245d87bb 100644 > > --- a/scripts/kconfig/qconf.cc > > +++ b/scripts/kconfig/qconf.cc > > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) > > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), > > rootEntry(0), headerPopup(0) > > { > > - int i; > > - > > setObjectName(name); > > setSortingEnabled(false); > > setRootIsDecorated(true); > > -- > > 2.17.1 > > > > -- > Kees Cook
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 82773cc35d35..50a5245d87bb 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), rootEntry(0), headerPopup(0) { - int i; - setObjectName(name); setSortingEnabled(false); setRootIsDecorated(true);
If this file were compiled with -Wall, the following warning would be reported: scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] int i; ^ The commit prepares to turn on -Wall for C++ host programs. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/kconfig/qconf.cc | 2 -- 1 file changed, 2 deletions(-)