[v2,2/5] t/lib-gpg.sh: stop pretending to be a stand-alone script
diff mbox series

Message ID c1811d54190a62e3d35505e2b806c89238b56de8.1585114881.git.gitgitgadget@gmail.com
State New
Headers show
Series
  • Untitled series #261173
Related show

Commit Message

Johannes Schindelin via GitGitGadget March 25, 2020, 5:41 a.m. UTC
From: Johannes Schindelin <johannes.schindelin@gmx.de>

It makes no sense to call `./lib-gpg.sh`. Therefore the hash-bang line
is unnecessary.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/lib-gpg.sh | 2 --
 1 file changed, 2 deletions(-)

Comments

Jeff King March 26, 2020, 8:21 a.m. UTC | #1
On Wed, Mar 25, 2020 at 05:41:18AM +0000, Johannes Schindelin via GitGitGadget wrote:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> It makes no sense to call `./lib-gpg.sh`. Therefore the hash-bang line
> is unnecessary.

I wondered if it might be useful to identify the file for editors, etc.
But "*.sh" is quite sufficient, and we already stripped most of these
out long ago in b54a31243b (t/lib-*.sh: drop executable bit,
2020-03-26).

There's some other related cleanup. I'll prepare a separate series.

-Peff
Johannes Schindelin March 26, 2020, 1:48 p.m. UTC | #2
Hi Peff,

On Thu, 26 Mar 2020, Jeff King wrote:

> On Wed, Mar 25, 2020 at 05:41:18AM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > It makes no sense to call `./lib-gpg.sh`. Therefore the hash-bang line
> > is unnecessary.
>
> I wondered if it might be useful to identify the file for editors, etc.
> But "*.sh" is quite sufficient, and we already stripped most of these
> out long ago in b54a31243b (t/lib-*.sh: drop executable bit,
> 2020-03-26).
>
> There's some other related cleanup. I'll prepare a separate series.

I noticed that, but forgot to add a note about this to the commit message.
Sorry. The next iteration of this patch series will have that note.

$ git grep '#! */' t/*.sh | grep -v 't[0-9]'
t/aggregate-results.sh:#!/bin/sh
t/gitweb-lib.sh:#!/usr/bin/perl
t/lib-credential.sh:#!/bin/sh

Thank you for volunteering to clean them up!

Ciao,
Dscho
Junio C Hamano March 26, 2020, 7:31 p.m. UTC | #3
Jeff King <peff@peff.net> writes:

> I wondered if it might be useful to identify the file for editors, etc.
> But "*.sh" is quite sufficient, and we already stripped most of these
> out long ago in b54a31243b (t/lib-*.sh: drop executable bit,
> 2020-03-26).

That timestamp look too fresh to me ;-)

c74c7203 (test: replace shebangs with descriptions in shell
libraries, 2013-11-25) was described quite well.

Patch
diff mbox series

diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index 11b83b8c24a..4ead1268351 100755
--- a/t/lib-gpg.sh
+++ b/t/lib-gpg.sh
@@ -1,5 +1,3 @@ 
-#!/bin/sh
-
 gpg_version=$(gpg --version 2>&1)
 if test $? != 127
 then