ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
diff mbox series

Message ID 20200325132913.110115-1-colin.king@canonical.com
State Accepted
Commit 633fddee7355e46a5b5ec471abb58d65e1e41012
Headers show
Series
  • ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
Related show

Commit Message

Colin King March 25, 2020, 1:29 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The signed 1 bit bitfields should be unsigned, so make them unsigned.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Codrin Ciubotariu March 25, 2020, 3:03 p.m. UTC | #1
On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
>          unsigned int                            frame_length;
>          int                                     tdm_slots;
>          int                                     channels;
> -       int                                     gclk_use:1;
> -       int                                     gclk_running:1;
> -       int                                     tx_rdy:1;
> -       int                                     rx_rdy:1;
> +       unsigned int                            gclk_use:1;
> +       unsigned int                            gclk_running:1;
> +       unsigned int                            tx_rdy:1;
> +       unsigned int                            rx_rdy:1;
>   };
> 
>   static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
>

Patch
diff mbox series

diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
index befc2a3a05b0..3cb63886195f 100644
--- a/sound/soc/atmel/mchp-i2s-mcc.c
+++ b/sound/soc/atmel/mchp-i2s-mcc.c
@@ -239,10 +239,10 @@  struct mchp_i2s_mcc_dev {
 	unsigned int				frame_length;
 	int					tdm_slots;
 	int					channels;
-	int					gclk_use:1;
-	int					gclk_running:1;
-	int					tx_rdy:1;
-	int					rx_rdy:1;
+	unsigned int				gclk_use:1;
+	unsigned int				gclk_running:1;
+	unsigned int				tx_rdy:1;
+	unsigned int				rx_rdy:1;
 };
 
 static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)