[ndctl] ndctl/README: Add a missing config setting
diff mbox series

Message ID BN7PR11MB28495CCA929E46ADEB9B6B9296CF0@BN7PR11MB2849.namprd11.prod.outlook.com
State New
Headers show
Series
  • [ndctl] ndctl/README: Add a missing config setting
Related show

Commit Message

Dorau, Lukasz March 26, 2020, 9:25 a.m. UTC
Add a missing config setting to README.md:
CONFIG_DEV_DAX_PMEM_COMPAT=m

Cc: Williams, Dan J <dan.j.williams@intel.com>
Cc: Verma, Vishal L <vishal.l.verma@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
---
 README.md | 1 +
 1 file changed, 1 insertion(+)

Comments

Vishal Verma March 26, 2020, 5:51 p.m. UTC | #1
On Thu, 2020-03-26 at 09:25 +0000, Dorau, Lukasz wrote:
> Add a missing config setting to README.md:
> CONFIG_DEV_DAX_PMEM_COMPAT=m
> 
> Cc: Williams, Dan J <dan.j.williams@intel.com>
> Cc: Verma, Vishal L <vishal.l.verma@intel.com>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
>  README.md | 1 +
>  1 file changed, 1 insertion(+)
> 
Thanks, looks good, I've pushed this out to a 'ld/readme' topic branch,
and it will make its way through pending and master.

	-Vishal
Dan Williams March 26, 2020, 6:45 p.m. UTC | #2
On Thu, Mar 26, 2020 at 2:25 AM Dorau, Lukasz <lukasz.dorau@intel.com> wrote:
>
> Add a missing config setting to README.md:
> CONFIG_DEV_DAX_PMEM_COMPAT=m

It's not required anymore as of:

https://github.com/pmem/ndctl/commit/b7991dbc22f31d03a38f3ee2dca4446fb55279e3
Dan Williams March 26, 2020, 6:47 p.m. UTC | #3
On Thu, Mar 26, 2020 at 11:45 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Thu, Mar 26, 2020 at 2:25 AM Dorau, Lukasz <lukasz.dorau@intel.com> wrote:
> >
> > Add a missing config setting to README.md:
> > CONFIG_DEV_DAX_PMEM_COMPAT=m
>
> It's not required anymore as of:
>
> https://github.com/pmem/ndctl/commit/b7991dbc22f31d03a38f3ee2dca4446fb55279e3

...and this kernel patch:

https://lore.kernel.org/linux-nvdimm/20200123154720.12097-1-jack@suse.cz/

Patch
diff mbox series

diff --git a/README.md b/README.md
index d296c6b..436ada3 100644
--- a/README.md
+++ b/README.md
@@ -65,6 +65,7 @@  loaded.  To build and install nfit_test.ko:
    CONFIG_NVDIMM_PFN=y
    CONFIG_NVDIMM_DAX=y
    CONFIG_DEV_DAX_PMEM=m
+   CONFIG_DEV_DAX_PMEM_COMPAT=m
    ```
 
 1. Build and install the unit test enabled libnvdimm modules in the