drm/i915/uc: Cleanup kerneldoc warnings
diff mbox series

Message ID 20200330212254.18236-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/uc: Cleanup kerneldoc warnings
Related show

Commit Message

Chris Wilson March 30, 2020, 9:22 p.m. UTC
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'supported' description in 'intel_uc_fw_init_early'
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'platform' description in 'intel_uc_fw_init_early'
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'rev' description in 'intel_uc_fw_init_early'

drivers/gpu/drm/i915/gt/uc/intel_guc_log.c:696: warning: Function parameter or member 'log' not described in 'intel_guc_log_info'
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c:696: warning: Excess function parameter 'guc' description in 'intel_guc_log_info'

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c   | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

Comments

Mika Kuoppala April 2, 2020, 6:53 p.m. UTC | #1
Chris Wilson <chris@chris-wilson.co.uk> writes:

> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'supported' description in 'intel_uc_fw_init_early'
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'platform' description in 'intel_uc_fw_init_early'
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c:205: warning: Excess function parameter 'rev' description in 'intel_uc_fw_init_early'
>
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c:696: warning: Function parameter or member 'log' not described in 'intel_guc_log_info'
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c:696: warning: Excess function parameter 'guc' description in 'intel_guc_log_info'
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c   | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 5b11a6d8e27f..fb10f3597ea5 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -687,7 +687,7 @@ stringify_guc_log_type(enum guc_log_buffer_type type)
>  
>  /**
>   * intel_guc_log_info - dump information about GuC log relay
> - * @guc: the GuC
> + * @log: the GuC log
>   * @p: the &drm_printer
>   *
>   * Pretty printer for GuC log info
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index fa893dd1823c..1f5d25f15340 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -193,9 +193,6 @@ static void __uc_fw_user_override(struct intel_uc_fw *uc_fw)
>   * intel_uc_fw_init_early - initialize the uC object and select the firmware
>   * @uc_fw: uC firmware
>   * @type: type of uC
> - * @supported: is uC support possible
> - * @platform: platform identifier
> - * @rev: hardware revision
>   *
>   * Initialize the state of our uC object and relevant tracking and select the
>   * firmware to fetch and load.
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 5b11a6d8e27f..fb10f3597ea5 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -687,7 +687,7 @@  stringify_guc_log_type(enum guc_log_buffer_type type)
 
 /**
  * intel_guc_log_info - dump information about GuC log relay
- * @guc: the GuC
+ * @log: the GuC log
  * @p: the &drm_printer
  *
  * Pretty printer for GuC log info
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index fa893dd1823c..1f5d25f15340 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -193,9 +193,6 @@  static void __uc_fw_user_override(struct intel_uc_fw *uc_fw)
  * intel_uc_fw_init_early - initialize the uC object and select the firmware
  * @uc_fw: uC firmware
  * @type: type of uC
- * @supported: is uC support possible
- * @platform: platform identifier
- * @rev: hardware revision
  *
  * Initialize the state of our uC object and relevant tracking and select the
  * firmware to fetch and load.