[PULL] gvt-next-fixes
mbox series

Message ID 20200331070025.GB16629@zhen-hp.sh.intel.com
State New
Headers show
Series
  • [PULL] gvt-next-fixes
Related show

Pull-request

https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2020-03-31

Message

Zhenyu Wang March 31, 2020, 7 a.m. UTC
Hi,

Here's more queued gvt fixes for 5.7. Please see details below.

Thanks
--
The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:

  drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2020-03-31

for you to fetch changes up to eb0ff8074e0baecba2cd0c7813f6cfa99bafc430:

  drm/i915/gvt: Fix klocwork issues about data size (2020-03-27 15:37:58 +0800)

----------------------------------------------------------------
gvt-next-fixes-2020-03-31

- Fix non-privilege access warning (Tina)
- Fix display port type (Tina)
- BDW cmd parser missed SWTESS_BASE_ADDRESS (Yan)
- Bypass length check of LRI (Yan)
- Fix one klocwork warning (Tina)

----------------------------------------------------------------
Tina Zhang (3):
      drm/i915/gvt: Add some regs to force-to-nonpriv whitelist
      drm/i915/gvt: Fix display port type issue
      drm/i915/gvt: Fix klocwork issues about data size

Yan Zhao (2):
      drm/i915/gvt: add support to command SWTESS_BASE_ADDRESS
      drm/i915/gvt: do not check len & max_len for lri

 drivers/gpu/drm/i915/gvt/cmd_parser.c | 16 ++++------------
 drivers/gpu/drm/i915/gvt/display.c    |  6 +++---
 drivers/gpu/drm/i915/gvt/handlers.c   |  8 ++++++--
 drivers/gpu/drm/i915/gvt/scheduler.c  |  4 ++--
 4 files changed, 15 insertions(+), 19 deletions(-)

Comments

Rodrigo Vivi March 31, 2020, 4:26 p.m. UTC | #1
On Tue, Mar 31, 2020 at 03:00:25PM +0800, Zhenyu Wang wrote:
> 
> Hi,
> 
> Here's more queued gvt fixes for 5.7. Please see details below.
> 
> Thanks
> --
> The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:
> 
>   drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2020-03-31
> 
> for you to fetch changes up to eb0ff8074e0baecba2cd0c7813f6cfa99bafc430:
> 
>   drm/i915/gvt: Fix klocwork issues about data size (2020-03-27 15:37:58 +0800)

pulled, thanks

> 
> ----------------------------------------------------------------
> gvt-next-fixes-2020-03-31
> 
> - Fix non-privilege access warning (Tina)
> - Fix display port type (Tina)
> - BDW cmd parser missed SWTESS_BASE_ADDRESS (Yan)
> - Bypass length check of LRI (Yan)
> - Fix one klocwork warning (Tina)
> 
> ----------------------------------------------------------------
> Tina Zhang (3):
>       drm/i915/gvt: Add some regs to force-to-nonpriv whitelist
>       drm/i915/gvt: Fix display port type issue
>       drm/i915/gvt: Fix klocwork issues about data size
> 
> Yan Zhao (2):
>       drm/i915/gvt: add support to command SWTESS_BASE_ADDRESS
>       drm/i915/gvt: do not check len & max_len for lri
> 
>  drivers/gpu/drm/i915/gvt/cmd_parser.c | 16 ++++------------
>  drivers/gpu/drm/i915/gvt/display.c    |  6 +++---
>  drivers/gpu/drm/i915/gvt/handlers.c   |  8 ++++++--
>  drivers/gpu/drm/i915/gvt/scheduler.c  |  4 ++--
>  4 files changed, 15 insertions(+), 19 deletions(-)
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Zhenyu Wang April 3, 2020, 3:05 a.m. UTC | #2
On 2020.03.31 09:26:44 -0700, Rodrigo Vivi wrote:
> On Tue, Mar 31, 2020 at 03:00:25PM +0800, Zhenyu Wang wrote:
> > 
> > Hi,
> > 
> > Here's more queued gvt fixes for 5.7. Please see details below.
> > 
> > Thanks
> > --
> > The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:
> > 
> >   drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
> > 
> > are available in the Git repository at:
> > 
> >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2020-03-31
> > 
> > for you to fetch changes up to eb0ff8074e0baecba2cd0c7813f6cfa99bafc430:
> > 
> >   drm/i915/gvt: Fix klocwork issues about data size (2020-03-27 15:37:58 +0800)
> 
> pulled, thanks

I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/

As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
yet, we'd need to backmerge and send pull against vfio merge for 5.7.

thanks

> 
> > 
> > ----------------------------------------------------------------
> > gvt-next-fixes-2020-03-31
> > 
> > - Fix non-privilege access warning (Tina)
> > - Fix display port type (Tina)
> > - BDW cmd parser missed SWTESS_BASE_ADDRESS (Yan)
> > - Bypass length check of LRI (Yan)
> > - Fix one klocwork warning (Tina)
> > 
> > ----------------------------------------------------------------
> > Tina Zhang (3):
> >       drm/i915/gvt: Add some regs to force-to-nonpriv whitelist
> >       drm/i915/gvt: Fix display port type issue
> >       drm/i915/gvt: Fix klocwork issues about data size
> > 
> > Yan Zhao (2):
> >       drm/i915/gvt: add support to command SWTESS_BASE_ADDRESS
> >       drm/i915/gvt: do not check len & max_len for lri
> > 
> >  drivers/gpu/drm/i915/gvt/cmd_parser.c | 16 ++++------------
> >  drivers/gpu/drm/i915/gvt/display.c    |  6 +++---
> >  drivers/gpu/drm/i915/gvt/handlers.c   |  8 ++++++--
> >  drivers/gpu/drm/i915/gvt/scheduler.c  |  4 ++--
> >  4 files changed, 15 insertions(+), 19 deletions(-)
> > 
> > -- 
> > Open Source Technology Center, Intel ltd.
> > 
> > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> 
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
Rodrigo Vivi April 3, 2020, 5:50 p.m. UTC | #3
+Dave and Daniel,

On Fri, Apr 03, 2020 at 11:05:07AM +0800, Zhenyu Wang wrote:
> On 2020.03.31 09:26:44 -0700, Rodrigo Vivi wrote:
> > On Tue, Mar 31, 2020 at 03:00:25PM +0800, Zhenyu Wang wrote:
> > > 
> > > Hi,
> > > 
> > > Here's more queued gvt fixes for 5.7. Please see details below.
> > > 
> > > Thanks
> > > --
> > > The following changes since commit a61ac1e75105a077ec1efd6923ae3c619f862304:
> > > 
> > >   drm/i915/gvt: Wean gvt off using dev_priv (2020-03-06 10:08:10 +0800)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://github.com/intel/gvt-linux.git tags/gvt-next-fixes-2020-03-31
> > > 
> > > for you to fetch changes up to eb0ff8074e0baecba2cd0c7813f6cfa99bafc430:
> > > 
> > >   drm/i915/gvt: Fix klocwork issues about data size (2020-03-27 15:37:58 +0800)
> > 
> > pulled, thanks
> 
> I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
> from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/
> 
> As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
> yet, we'd need to backmerge and send pull against vfio merge for 5.7.

I'm not sure if I'm following on which backmerge you are willing
us to do here. And for me it looks like late for 5.7 already.

Maybe you mean we ack all of this to go through vfio flow
then once that is settled drm backmerge and then drm-intel backmerge
and you backmerge...

Is that what you want?

> 
> thanks
> 
> > 
> > > 
> > > ----------------------------------------------------------------
> > > gvt-next-fixes-2020-03-31
> > > 
> > > - Fix non-privilege access warning (Tina)
> > > - Fix display port type (Tina)
> > > - BDW cmd parser missed SWTESS_BASE_ADDRESS (Yan)
> > > - Bypass length check of LRI (Yan)
> > > - Fix one klocwork warning (Tina)
> > > 
> > > ----------------------------------------------------------------
> > > Tina Zhang (3):
> > >       drm/i915/gvt: Add some regs to force-to-nonpriv whitelist
> > >       drm/i915/gvt: Fix display port type issue
> > >       drm/i915/gvt: Fix klocwork issues about data size
> > > 
> > > Yan Zhao (2):
> > >       drm/i915/gvt: add support to command SWTESS_BASE_ADDRESS
> > >       drm/i915/gvt: do not check len & max_len for lri
> > > 
> > >  drivers/gpu/drm/i915/gvt/cmd_parser.c | 16 ++++------------
> > >  drivers/gpu/drm/i915/gvt/display.c    |  6 +++---
> > >  drivers/gpu/drm/i915/gvt/handlers.c   |  8 ++++++--
> > >  drivers/gpu/drm/i915/gvt/scheduler.c  |  4 ++--
> > >  4 files changed, 15 insertions(+), 19 deletions(-)
> > > 
> > > -- 
> > > Open Source Technology Center, Intel ltd.
> > > 
> > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> > 
> > 
> > _______________________________________________
> > intel-gvt-dev mailing list
> > intel-gvt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827



> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Zhenyu Wang April 7, 2020, 8:02 a.m. UTC | #4
On 2020.04.03 10:50:33 -0700, Rodrigo Vivi wrote:
> 
> +Dave and Daniel,
> 
> > 
> > I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
> > from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/
> > 
> > As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
> > yet, we'd need to backmerge and send pull against vfio merge for 5.7.
> 
> I'm not sure if I'm following on which backmerge you are willing
> us to do here. And for me it looks like late for 5.7 already.
> 
> Maybe you mean we ack all of this to go through vfio flow
> then once that is settled drm backmerge and then drm-intel backmerge
> and you backmerge...
> 
> Is that what you want?
> 

My purpose is to get GVT side fixes of guest memory r/w through new
vfio dma r/w interface in 5.7. As vfio 5.7-rc1 pull has already been
merged in linus master, looks just want drm-intel backmerge now then
could send gvt side fixes. Ok for you?

Sorry for late reply, I was out for a short vacation.

Thanks
Rodrigo Vivi April 7, 2020, 1:35 p.m. UTC | #5
On Tue, Apr 07, 2020 at 04:02:56PM +0800, Zhenyu Wang wrote:
> On 2020.04.03 10:50:33 -0700, Rodrigo Vivi wrote:
> > 
> > +Dave and Daniel,
> > 
> > > 
> > > I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
> > > from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/
> > > 
> > > As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
> > > yet, we'd need to backmerge and send pull against vfio merge for 5.7.
> > 
> > I'm not sure if I'm following on which backmerge you are willing
> > us to do here. And for me it looks like late for 5.7 already.
> > 
> > Maybe you mean we ack all of this to go through vfio flow
> > then once that is settled drm backmerge and then drm-intel backmerge
> > and you backmerge...
> > 
> > Is that what you want?
> > 
> 
> My purpose is to get GVT side fixes of guest memory r/w through new
> vfio dma r/w interface in 5.7. As vfio 5.7-rc1 pull has already been
> merged in linus master, looks just want drm-intel backmerge now then
> could send gvt side fixes. Ok for you?

I'm afraid it is too late for that. That would depend on backmerge
of drm itself as well... And we are in a point that we are about to
move from drm-next to drm-fixes.

Also looking to the patches itself they look more content for -next
than -fixes and our window with drm closed on -rc6

So it looks to me that this will have to wait for the 5.8.

One good suggestion I heard from Daniel for cases like this in the
future is the use of topic branches so things don't get spread into
multiple versions like this.

> 
> Sorry for late reply, I was out for a short vacation.

Sorry for not been able to help further here

Thanks,
Rodrigo.

> 
> Thanks
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Jani Nikula April 7, 2020, 1:53 p.m. UTC | #6
On Tue, 07 Apr 2020, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Tue, Apr 07, 2020 at 04:02:56PM +0800, Zhenyu Wang wrote:
>> On 2020.04.03 10:50:33 -0700, Rodrigo Vivi wrote:
>> > 
>> > +Dave and Daniel,
>> > 
>> > > 
>> > > I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
>> > > from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/
>> > > 
>> > > As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
>> > > yet, we'd need to backmerge and send pull against vfio merge for 5.7.
>> > 
>> > I'm not sure if I'm following on which backmerge you are willing
>> > us to do here. And for me it looks like late for 5.7 already.
>> > 
>> > Maybe you mean we ack all of this to go through vfio flow
>> > then once that is settled drm backmerge and then drm-intel backmerge
>> > and you backmerge...
>> > 
>> > Is that what you want?
>> > 
>> 
>> My purpose is to get GVT side fixes of guest memory r/w through new
>> vfio dma r/w interface in 5.7. As vfio 5.7-rc1 pull has already been
>> merged in linus master, looks just want drm-intel backmerge now then
>> could send gvt side fixes. Ok for you?
>
> I'm afraid it is too late for that. That would depend on backmerge
> of drm itself as well... And we are in a point that we are about to
> move from drm-next to drm-fixes.

*If* they're fixes, drm-intel-fixes rebases on v5.7-rc1 or -rc2, and if
they can send a gvt fixes pull based on that, it could work out.

BR,
Jani.


>
> Also looking to the patches itself they look more content for -next
> than -fixes and our window with drm closed on -rc6
>
> So it looks to me that this will have to wait for the 5.8.
>
> One good suggestion I heard from Daniel for cases like this in the
> future is the use of topic branches so things don't get spread into
> multiple versions like this.
>
>> 
>> Sorry for late reply, I was out for a short vacation.
>
> Sorry for not been able to help further here
>
> Thanks,
> Rodrigo.
>
>> 
>> Thanks
>> 
>> -- 
>> Open Source Technology Center, Intel ltd.
>> 
>> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>
>
Zhenyu Wang April 7, 2020, 11:36 p.m. UTC | #7
On 2020.04.07 16:53:19 +0300, Jani Nikula wrote:
> On Tue, 07 Apr 2020, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> > On Tue, Apr 07, 2020 at 04:02:56PM +0800, Zhenyu Wang wrote:
> >> On 2020.04.03 10:50:33 -0700, Rodrigo Vivi wrote:
> >> > 
> >> > +Dave and Daniel,
> >> > 
> >> > > 
> >> > > I forgot to mention one thing for 5.7. We've fixed to change guest mem r/w
> >> > > from KVM to use new VFIO dma r/w instead in this series: https://patchwork.freedesktop.org/series/72038/
> >> > > 
> >> > > As this depends on VFIO tree and looks VFIO pull for 5.7 is not settled down
> >> > > yet, we'd need to backmerge and send pull against vfio merge for 5.7.
> >> > 
> >> > I'm not sure if I'm following on which backmerge you are willing
> >> > us to do here. And for me it looks like late for 5.7 already.
> >> > 
> >> > Maybe you mean we ack all of this to go through vfio flow
> >> > then once that is settled drm backmerge and then drm-intel backmerge
> >> > and you backmerge...
> >> > 
> >> > Is that what you want?
> >> > 
> >> 
> >> My purpose is to get GVT side fixes of guest memory r/w through new
> >> vfio dma r/w interface in 5.7. As vfio 5.7-rc1 pull has already been
> >> merged in linus master, looks just want drm-intel backmerge now then
> >> could send gvt side fixes. Ok for you?
> >
> > I'm afraid it is too late for that. That would depend on backmerge
> > of drm itself as well... And we are in a point that we are about to
> > move from drm-next to drm-fixes.
> 
> *If* they're fixes, drm-intel-fixes rebases on v5.7-rc1 or -rc2, and if
> they can send a gvt fixes pull based on that, it could work out.
> 

yeah, that's also what I'm thinking about. Here's more background.

In gvt we need to access guest pages in some places, our current way
is to call KVM interface, but it turns out later that this interface
is supposed to be used by arch code only and what we should actually
depend on is using IOVA for guest page access instead of using guest
physical address by KVM. So we tried to add IOVA based guest r/w
support for VFIO and change gvt to use that. In that way they're real
fixes to me.

> >
> > Also looking to the patches itself they look more content for -next
> > than -fixes and our window with drm closed on -rc6

I understand that but the patches mostly for vfio interface hadn't been
finalized during rc6 window..

> >
> > So it looks to me that this will have to wait for the 5.8.
> >
> > One good suggestion I heard from Daniel for cases like this in the
> > future is the use of topic branches so things don't get spread into
> > multiple versions like this.
> >

Good idea. Does that mean such topic branch could be merged during
e.g -rc1 merge window?

Thanks

> >> 
> >> Sorry for late reply, I was out for a short vacation.
> >
> > Sorry for not been able to help further here
> >
> > Thanks,
> > Rodrigo.
> >
> >> 
> >> Thanks
> >> 
> >> -- 
> >> Open Source Technology Center, Intel ltd.
> >> 
> >> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
> >
> >
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center