[1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt
diff mbox series

Message ID 20200331091459.29179-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • [1/4] drm/i915/selftests: Tidy up an error message for live_error_interrupt
Related show

Commit Message

Chris Wilson March 31, 2020, 9:14 a.m. UTC
Since we don't wait for the error interrupt to reset, restart and then
complete the guilty request, clean up the error messages.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Mika Kuoppala March 31, 2020, 1:07 p.m. UTC | #1
Chris Wilson <chris@chris-wilson.co.uk> writes:

> Since we don't wait for the error interrupt to reset, restart and then
> complete the guilty request, clean up the error messages.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/selftest_lrc.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index d3e163c93e22..b929e52a8f5a 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -649,9 +649,9 @@ static int live_error_interrupt(void *arg)
>  						 error_repr(p->error[i]));
>  
>  				if (!i915_request_started(client[i])) {
> -					pr_debug("%s: %s request not stated!\n",
> -						 engine->name,
> -						 error_repr(p->error[i]));
> +					pr_err("%s: %s request not started!\n",
> +					       engine->name,
> +					       error_repr(p->error[i]));
>  					err = -ETIME;
>  					goto out;
>  				}
> @@ -659,9 +659,10 @@ static int live_error_interrupt(void *arg)
>  				/* Kick the tasklet to process the error */
>  				intel_engine_flush_submission(engine);
>  				if (client[i]->fence.error != p->error[i]) {
> -					pr_err("%s: %s request completed with wrong error code: %d\n",
> +					pr_err("%s: %s request (%s) with wrong error code: %d\n",
>  					       engine->name,
>  					       error_repr(p->error[i]),
> +					       i915_request_completed(client[i]) ? "completed" : "running",
>  					       client[i]->fence.error);
>  					err = -EINVAL;
>  					goto out;
> -- 
> 2.20.1

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index d3e163c93e22..b929e52a8f5a 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -649,9 +649,9 @@  static int live_error_interrupt(void *arg)
 						 error_repr(p->error[i]));
 
 				if (!i915_request_started(client[i])) {
-					pr_debug("%s: %s request not stated!\n",
-						 engine->name,
-						 error_repr(p->error[i]));
+					pr_err("%s: %s request not started!\n",
+					       engine->name,
+					       error_repr(p->error[i]));
 					err = -ETIME;
 					goto out;
 				}
@@ -659,9 +659,10 @@  static int live_error_interrupt(void *arg)
 				/* Kick the tasklet to process the error */
 				intel_engine_flush_submission(engine);
 				if (client[i]->fence.error != p->error[i]) {
-					pr_err("%s: %s request completed with wrong error code: %d\n",
+					pr_err("%s: %s request (%s) with wrong error code: %d\n",
 					       engine->name,
 					       error_repr(p->error[i]),
+					       i915_request_completed(client[i]) ? "completed" : "running",
 					       client[i]->fence.error);
 					err = -EINVAL;
 					goto out;