[2/3] ASoC: topology: use name_prefix for new kcontrol
diff mbox series

Message ID 004c01d607be$68cd8b50$3a68a1f0$@samsung.com
State New
Headers show
Series
  • Untitled series #264615
Related show

Commit Message

Gyeongtaek Lee April 1, 2020, 12:42 a.m. UTC
Current topology doesn't add prefix of component to new kcontrol.

Signed-off-by: Gyeongtaek Lee <gt82.lee@samsung.com>
---
 sound/soc/soc-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown April 1, 2020, 8:37 a.m. UTC | #1
On Wed, Apr 01, 2020 at 09:42:23AM +0900, �̰��� wrote:
> Current topology doesn't add prefix of component to new kcontrol.

Please only number patches if you are sending them as part of a patch
series, the purpose of numbering is to make sure that things get handled
in the right order.  Without a series it looks like there are some
missing patches.
Gyeongtaek Lee April 1, 2020, 9:22 a.m. UTC | #2
On Wed, Apr 01, 2020 at 09:37:08AM +0100, Mark Brown wrote:
>On Wed, Apr 01, 2020 at 09:42:23AM +0900, �̰��� wrote:
>> Current topology doesn't add prefix of component to new kcontrol.
>
>Please only number patches if you are sending them as part of a patch
>series, the purpose of numbering is to make sure that things get handled
>in the right order.  Without a series it looks like there are some
>missing patches.
>
I'm trying to catch up the merge process now.
Let me know if anything has gone wrong.
I removed the patch number and re-sent the patch again.

Sorry and thank you for your review.

Patch
diff mbox series

diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c
index 575da6aba807..a152409e8746 100644
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -362,7 +362,7 @@  static int soc_tplg_add_kcontrol(struct soc_tplg *tplg,
 	struct snd_soc_component *comp = tplg->comp;
 
 	return soc_tplg_add_dcontrol(comp->card->snd_card,
-				comp->dev, k, NULL, comp, kcontrol);
+				comp->dev, k, comp->name_prefix, comp, kcontrol);
 }
 
 /* remove a mixer kcontrol */