| Message ID | 20200401032150.19767-1-yamada.masahiro@socionext.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | aee45dba3ad9c87affa95e50747fbb82ff4b2e20 |
| Headers | show |
| Series | dt-bindings: dma: uniphier-xdmac: switch to single reg region | expand |
On Wed, 1 Apr 2020 12:21:50 +0900, Masahiro Yamada wrote: > The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>" > is wrong. The register region of this controller is much smaller, > and there is no other hardware register interleaved. There is no > good reason to split it into two regions. > > Just use a single, contiguous register region. > > While I am here, I made the 'dma-channels' property mandatory because > otherwise there is no way to determine the number of the channels. > > Please note the original binding was merged recently. Since there > is no user yet, this change has no actual impact. > > Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings") > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > We do not need to touch the driver either because the second > region is not used. > > > .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 01-04-20, 12:21, Masahiro Yamada wrote: > The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>" > is wrong. The register region of this controller is much smaller, > and there is no other hardware register interleaved. There is no > good reason to split it into two regions. > > Just use a single, contiguous register region. > > While I am here, I made the 'dma-channels' property mandatory because > otherwise there is no way to determine the number of the channels. > > Please note the original binding was merged recently. Since there > is no user yet, this change has no actual impact. Applied, thanks
diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml index 86cfb599256e..371f18773198 100644 --- a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml @@ -22,9 +22,7 @@ properties: const: socionext,uniphier-xdmac reg: - items: - - description: XDMAC base register region (offset and length) - - description: XDMAC extension register region (offset and length) + maxItems: 1 interrupts: maxItems: 1 @@ -49,12 +47,13 @@ required: - reg - interrupts - "#dma-cells" + - dma-channels examples: - | xdmac: dma-controller@5fc10000 { compatible = "socionext,uniphier-xdmac"; - reg = <0x5fc10000 0x1000>, <0x5fc20000 0x800>; + reg = <0x5fc10000 0x5300>; interrupts = <0 188 4>; #dma-cells = <2>; dma-channels = <16>;
The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>" is wrong. The register region of this controller is much smaller, and there is no other hardware register interleaved. There is no good reason to split it into two regions. Just use a single, contiguous register region. While I am here, I made the 'dma-channels' property mandatory because otherwise there is no way to determine the number of the channels. Please note the original binding was merged recently. Since there is no user yet, this change has no actual impact. Fixes: b9fb56b6ba8a ("dt-bindings: dmaengine: Add UniPhier external DMA controller bindings") Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- We do not need to touch the driver either because the second region is not used. .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)