| Message ID | 20200401083909.18886-2-benjamin.gaignard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clockevent: add low power STM32 timer | expand |
On 4/1/20 10:39 AM, Benjamin Gaignard wrote: > Add a subnode to STM low power timer bindings to support timer driver > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > version 6: > - only use one interrupt > > version 5: > - the previous has been acked-by Rob but since I have docummented > interrupts and interrupt-names properties I haven't applied it here. > > version 4: > - change compatible and subnode names > - document wakeup-source property > > .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > Hi Benjamin, Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com> Thanks, Fabrice > diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > index 1a4cc5f3fb33..2a99b2296d2b 100644 > --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml > @@ -33,12 +33,17 @@ properties: > items: > - const: mux > > + interrupts: > + maxItems: 1 > + > "#address-cells": > const: 1 > > "#size-cells": > const: 0 > > + wakeup-source: true > + > pwm: > type: object > > @@ -81,6 +86,16 @@ patternProperties: > required: > - compatible > > + timer: > + type: object > + > + properties: > + compatible: > + const: st,stm32-lptimer-timer > + > + required: > + - compatible > + > required: > - "#address-cells" > - "#size-cells" > @@ -94,11 +109,13 @@ additionalProperties: false > examples: > - | > #include <dt-bindings/clock/stm32mp1-clks.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > timer@40002400 { > compatible = "st,stm32-lptimer"; > reg = <0x40002400 0x400>; > clocks = <&timer_clk>; > clock-names = "mux"; > + interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>; > #address-cells = <1>; > #size-cells = <0>; > > @@ -115,6 +132,10 @@ examples: > counter { > compatible = "st,stm32-lptimer-counter"; > }; > + > + timer { > + compatible = "st,stm32-lptimer-timer"; > + }; > }; > > ... >
On Wed, 01 Apr 2020, Benjamin Gaignard wrote: > Add a subnode to STM low power timer bindings to support timer driver > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > version 6: > - only use one interrupt > > version 5: > - the previous has been acked-by Rob but since I have docummented > interrupts and interrupt-names properties I haven't applied it here. > > version 4: > - change compatible and subnode names > - document wakeup-source property > > .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml index 1a4cc5f3fb33..2a99b2296d2b 100644 --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml @@ -33,12 +33,17 @@ properties: items: - const: mux + interrupts: + maxItems: 1 + "#address-cells": const: 1 "#size-cells": const: 0 + wakeup-source: true + pwm: type: object @@ -81,6 +86,16 @@ patternProperties: required: - compatible + timer: + type: object + + properties: + compatible: + const: st,stm32-lptimer-timer + + required: + - compatible + required: - "#address-cells" - "#size-cells" @@ -94,11 +109,13 @@ additionalProperties: false examples: - | #include <dt-bindings/clock/stm32mp1-clks.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> timer@40002400 { compatible = "st,stm32-lptimer"; reg = <0x40002400 0x400>; clocks = <&timer_clk>; clock-names = "mux"; + interrupts-extended = <&exti 47 IRQ_TYPE_LEVEL_HIGH>; #address-cells = <1>; #size-cells = <0>; @@ -115,6 +132,10 @@ examples: counter { compatible = "st,stm32-lptimer-counter"; }; + + timer { + compatible = "st,stm32-lptimer-timer"; + }; }; ...