[04/10] NFS: Fix a request reference leak in nfs_direct_write_clear_reqs()
diff mbox series

Message ID 20200401185652.1904777-5-trondmy@kernel.org
State New
Headers show
  • NFS: Fix a number of memory leaks and use-after-free
Related show

Commit Message

trondmy@kernel.org April 1, 2020, 6:56 p.m. UTC
From: Trond Myklebust <trond.myklebust@hammerspace.com>

nfs_direct_write_scan_commit_list() will lock the request and bump
the reference count, but we also need to account for the reference
that was taken when we initially added the request to the commit list.

Fixes: fb5f7f20cdb9 ("NFS: commit errors should be fatal")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
 fs/nfs/direct.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 51ab4627c4d6..8074304fd5b4 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -646,6 +646,7 @@  static void nfs_direct_write_clear_reqs(struct nfs_direct_req *dreq)
 	while (!list_empty(&reqs)) {
 		req = nfs_list_entry(reqs.next);
+		nfs_release_request(req);