[119/155] mm: vmpressure: don't need call kfree if kstrndup fails

Commit Message

Andrew Morton April 2, 2020, 4:09 a.m. UTC

From: Yang Shi <[e-mail]>
Subject: mm: vmpressure: don't need call kfree if kstrndup fails

When kstrndup fails, no memory was allocated and we can exit directly.

[[e-mail]: reword changelog]
Link: http://lkml.kernel.org/r/[e-mail]
Signed-off-by: Yang Shi <[e-mail]>
Reviewed-by: Andrew Morton <[e-mail]>
Reviewed-by: David Hildenbrand <[e-mail]>
Acked-by: David Rientjes <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 mm/vmpressure.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Patch

--- a/mm/vmpressure.c~mm-vmpressure-dont-need-call-kfree-if-kstrndup-fails
+++ a/mm/vmpressure.c
@@ -371,10 +371,8 @@  int vmpressure_register_event(struct mem
 	int ret = 0;
 
 	spec_orig = spec = kstrndup(args, MAX_VMPRESSURE_ARGS_LEN, GFP_KERNEL);
-	if (!spec) {
-		ret = -ENOMEM;
-		goto out;
-	}
+	if (!spec)
+		return -ENOMEM;
 
 	/* Find required level */
 	token = strsep(&spec, ",");