git-submodule.sh: setup uninitialized variables

Commit Message

Jiang Xin April 2, 2020, 8:42 a.m. UTC

From: xuejiang <[e-mail]>

We have an environment variable `jobs=16` defined in our CI system, and
this environment makes our build job failed with the following message:

    error: pathspec '16' did not match any file(s) known to git

The pathspect '16' for Git command is from the environment variable
"jobs".

This is because "git-submodule" command is implemented in shell script,
and environment variables may change its behavior.  Set values for
uninitialized variables, such as "jobs" and "recommend_shallow" will
fix this issue.

Helped-by: Jiang Xin <[e-mail]>
Signed-off-by: Li Xuejiang <[e-mail]>
---
 git-submodule.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Sunshine April 2, 2020, 3:11 p.m. UTC | #1

On Thu, Apr 2, 2020 at 4:43 AM Jiang Xin <[e-mail]> wrote:
> We have an environment variable `jobs=16` defined in our CI system, and
> this environment makes our build job failed with the following message:
>
>     error: pathspec '16' did not match any file(s) known to git
>
> The pathspect '16' for Git command is from the environment variable
> "jobs".

s/pathspect/pathspec/

> This is because "git-submodule" command is implemented in shell script,
> and environment variables may change its behavior.  Set values for
> uninitialized variables, such as "jobs" and "recommend_shallow" will
> fix this issue.
>
> Helped-by: Jiang Xin <[e-mail]>
> Signed-off-by: Li Xuejiang <[e-mail]>

Jiang Xin April 3, 2020, 2:56 a.m. UTC | #2

Eric Sunshine <[e-mail]> 于2020年4月2日周四 下午11:11写道：
>
> On Thu, Apr 2, 2020 at 4:43 AM Jiang Xin <[e-mail]> wrote:
> > We have an environment variable `jobs=16` defined in our CI system, and
> > this environment makes our build job failed with the following message:
> >
> >     error: pathspec '16' did not match any file(s) known to git
> >
> > The pathspect '16' for Git command is from the environment variable
> > "jobs".
>
> s/pathspect/pathspec/

Thanks, Eric.  I find Junio has already fixed the typo in his feature branch:

* https://github.com/gitster/git/commits/lx/submodule-clear-variables

Patch

diff --git a/git-submodule.sh b/git-submodule.sh
index 1cb2c0a31b..d69d24a857 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -43,6 +43,8 @@  custom_name=
 depth=
 progress=
 dissociate=
+jobs=
+recommend_shallow=
 
 die_if_unmatched ()
 {