ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen
diff mbox series

Message ID 20200402174311.238614-1-hdegoede@redhat.com
State New
Headers show
Series
  • ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen
Related show

Commit Message

Hans de Goede April 2, 2020, 5:43 p.m. UTC
The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
the Lenovo Carbon X1 7th gen, as such it needs the same
ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.

This fixes volume control of the speaker not working among other things.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
Cc: stable@vger.kernel.org
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jaroslav Kysela April 2, 2020, 5:53 p.m. UTC | #1
Dne 02. 04. 20 v 19:43 Hans de Goede napsal(a):
> The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
> the Lenovo Carbon X1 7th gen, as such it needs the same
> ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.
> 
> This fixes volume control of the speaker not working among other things.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
> Cc: stable@vger.kernel.org
> Suggested-by: Jaroslav Kysela <perex@perex.cz>

Reviewed-by: Jaroslav Kysela <perex@perex.cz>

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 63e1a56f705b..9c3bbf1df93e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7299,6 +7299,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>   	SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
>   	SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
> +	SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
>   	SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
>   	SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
>   	SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>
Takashi Iwai April 2, 2020, 6:43 p.m. UTC | #2
On Thu, 02 Apr 2020 19:43:11 +0200,
Hans de Goede wrote:
> 
> The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
> the Lenovo Carbon X1 7th gen, as such it needs the same
> ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.
> 
> This fixes volume control of the speaker not working among other things.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
> Cc: stable@vger.kernel.org
> Suggested-by: Jaroslav Kysela <perex@perex.cz>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied now, thanks.


Takashi

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 63e1a56f705b..9c3bbf1df93e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7299,6 +7299,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
 	SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
 	SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
+	SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
 	SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
 	SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
 	SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),