Message ID | 20200402184948.3014-2-hdegoede@redhat.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 904f353d0e508fb4b3a3f902a02b0a028cda33a6 |
Headers | show |
Series | [1/2] ASoC: SOF: Fix "no reply expected" error during firmware-boot | expand |
On 4/2/20 1:49 PM, Hans de Goede wrote: > Using a Canon Lake machine with the SOF driver causes dmesg to fill > up with a ton of these messages: > > [ 275.902194] sof-audio-pci 0000:00:1f.3: firmware boot complete > [ 351.529358] sof-audio-pci 0000:00:1f.3: firmware boot complete > [ 560.049047] sof-audio-pci 0000:00:1f.3: firmware boot complete > etc. > > Since the DSP is powered down when not in used this happens everytime > e.g. a notification plays, polluting dmesg. > > Turn this messages into a debug message, matching what the code already > does for the ""booting DSP firmware" message. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Thanks Hans. > --- > sound/soc/sof/loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c > index fc4ab51bacf4..4760a9734585 100644 > --- a/sound/soc/sof/loader.c > +++ b/sound/soc/sof/loader.c > @@ -603,7 +603,7 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev) > } > > if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) > - dev_info(sdev->dev, "firmware boot complete\n"); > + dev_dbg(sdev->dev, "firmware boot complete\n"); > else > return -EIO; /* FW boots but fw_ready op failed */ > >
diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c index fc4ab51bacf4..4760a9734585 100644 --- a/sound/soc/sof/loader.c +++ b/sound/soc/sof/loader.c @@ -603,7 +603,7 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev) } if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) - dev_info(sdev->dev, "firmware boot complete\n"); + dev_dbg(sdev->dev, "firmware boot complete\n"); else return -EIO; /* FW boots but fw_ready op failed */
Using a Canon Lake machine with the SOF driver causes dmesg to fill up with a ton of these messages: [ 275.902194] sof-audio-pci 0000:00:1f.3: firmware boot complete [ 351.529358] sof-audio-pci 0000:00:1f.3: firmware boot complete [ 560.049047] sof-audio-pci 0000:00:1f.3: firmware boot complete etc. Since the DSP is powered down when not in used this happens everytime e.g. a notification plays, polluting dmesg. Turn this messages into a debug message, matching what the code already does for the ""booting DSP firmware" message. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- sound/soc/sof/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)