[v6,02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST
diff mbox series

Message ID 1585856319-4380-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series
  • Add support for PCIe controller to work in endpoint mode on R-Car SoCs
Related show

Commit Message

Lad Prabhakar April 2, 2020, 7:38 p.m. UTC
config option PCIE_RCAR internally selects PCIE_RCAR_HOST which builds the
same driver. So this patch renames CONFIG_PCIE_RCAR to
CONFIG_PCIE_RCAR_HOST so that PCIE_RCAR can be safely dropped from Kconfig
file.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yoshihiro Shimoda April 3, 2020, 8:03 a.m. UTC | #1
Hi Prabhakar-san,

> From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM
> 
> config option PCIE_RCAR internally selects PCIE_RCAR_HOST which builds the
> same driver. So this patch renames CONFIG_PCIE_RCAR to
> CONFIG_PCIE_RCAR_HOST so that PCIE_RCAR can be safely dropped from Kconfig
> file.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

But, I'm thinking this patch (and patch 03/11) should be separated
from this patch series for arm64 subsystem to ease maintenance.
My scenario is:
 1) patch series 1: R-Car PCIe endpoint support.
 -- This means: patch 1, 4 - 9, 11

 2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
   and submit the patch 10/11 to misc subsystem.

 3) At last, submit patch 3/11 after the patch 2/11 is merged.

Geert-san, what do you think?

Best regards,
Yoshihiro Shimoda
Geert Uytterhoeven April 3, 2020, 8:28 a.m. UTC | #2
Hi Shimoda-san,

On Fri, Apr 3, 2020 at 10:03 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM
> >
> > config option PCIE_RCAR internally selects PCIE_RCAR_HOST which builds the
> > same driver. So this patch renames CONFIG_PCIE_RCAR to
> > CONFIG_PCIE_RCAR_HOST so that PCIE_RCAR can be safely dropped from Kconfig
> > file.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thank you for the patch!
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> But, I'm thinking this patch (and patch 03/11) should be separated
> from this patch series for arm64 subsystem to ease maintenance.
> My scenario is:
>  1) patch series 1: R-Car PCIe endpoint support.
>  -- This means: patch 1, 4 - 9, 11
>
>  2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
>    and submit the patch 10/11 to misc subsystem.
>
>  3) At last, submit patch 3/11 after the patch 2/11 is merged.
>
> Geert-san, what do you think?

Thanks, I agree with your summary.

I can take patch 2/11 through renesas-devel.
Probably it's best if I submit it to arm-soc as a fix for v5.8, after
the driver part
has been merged into v5.8-rc1, so 3/11 can be submitted for v5.9.

BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
mask for PCIEPAMR register". Can the issue fixed by this patch happen with
the current driver in host mode, or is that limited to ep mode?
In case of the former, please submit it to the PCI maintainer as a separate
fix.

Thanks!

Gr{oetje,eeting}s,

                        Geert
Yoshihiro Shimoda April 3, 2020, 9:04 a.m. UTC | #3
Hi Geert-san,

Thank you for your comments!

> From: Geert Uytterhoeven, Sent: Friday, April 3, 2020 5:28 PM
<snip>
> > But, I'm thinking this patch (and patch 03/11) should be separated
> > from this patch series for arm64 subsystem to ease maintenance.
> > My scenario is:
> >  1) patch series 1: R-Car PCIe endpoint support.
> >  -- This means: patch 1, 4 - 9, 11
> >
> >  2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
> >    and submit the patch 10/11 to misc subsystem.
> >
> >  3) At last, submit patch 3/11 after the patch 2/11 is merged.
> >
> > Geert-san, what do you think?
> 
> Thanks, I agree with your summary.
> 
> I can take patch 2/11 through renesas-devel.
> Probably it's best if I submit it to arm-soc as a fix for v5.8, after
> the driver part
> has been merged into v5.8-rc1, so 3/11 can be submitted for v5.9.

Thank you! I got it.

> BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
> mask for PCIEPAMR register". Can the issue fixed by this patch happen with
> the current driver in host mode, or is that limited to ep mode?
> In case of the former, please submit it to the PCI maintainer as a separate
> fix.

Thank you for pointed it out. I think this is the case of the former.
IIUC, if such a small window PCIe device exists, the issue happens.

Prabhakar-san, is my understanding correct?

Best regards,
Yoshihiro Shimoda
Lad Prabhakar April 3, 2020, 9:31 a.m. UTC | #4
Hi Shimoda-san/Geert-san,

> -----Original Message-----
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Sent: 03 April 2020 10:05
> To: Geert Uytterhoeven <geert@linux-m68k.org>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Will Deacon <will@kernel.org>; Geert Uytterhoeven <geert+renesas@glider.be>; Catalin Marinas <catalin.marinas@arm.com>; Arnd
> Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Andrew Murray <andrew.murray@arm.com>;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-renesas-soc@vger.kernel.org; Chris
> Paterson <Chris.Paterson2@renesas.com>; Frank Rowand <frowand.list@gmail.com>; Gustavo Pimentel
> <gustavo.pimentel@synopsys.com>; Jingoo Han <jingoohan1@gmail.com>; Simon Horman <horms@verge.net.au>; Shawn Lin
> <shawn.lin@rock-chips.com>; Tom Joseph <tjoseph@cadence.com>; Heiko Stuebner <heiko@sntech.de>; linux-
> rockchip@lists.infradead.org; Lad Prabhakar <prabhakar.csengg@gmail.com>; Magnus Damm <magnus.damm@gmail.com>; Kishon Vijay
> Abraham I <kishon@ti.com>; Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>; Marek Vasut <marek.vasut+renesas@gmail.com>; linux-
> pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>
> Subject: RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST
>
> Hi Geert-san,
>
> Thank you for your comments!
>
> > From: Geert Uytterhoeven, Sent: Friday, April 3, 2020 5:28 PM
> <snip>
> > > But, I'm thinking this patch (and patch 03/11) should be separated
> > > from this patch series for arm64 subsystem to ease maintenance.
> > > My scenario is:
> > >  1) patch series 1: R-Car PCIe endpoint support.
> > >  -- This means: patch 1, 4 - 9, 11
> > >
> > >  2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
> > >    and submit the patch 10/11 to misc subsystem.
> > >
> > >  3) At last, submit patch 3/11 after the patch 2/11 is merged.
> > >
> > > Geert-san, what do you think?
> >
> > Thanks, I agree with your summary.
> >
> > I can take patch 2/11 through renesas-devel.
> > Probably it's best if I submit it to arm-soc as a fix for v5.8, after
> > the driver part
> > has been merged into v5.8-rc1, so 3/11 can be submitted for v5.9.
>
> Thank you! I got it.
>
Thank you, Ill split the patches accordingly and post a v7.

> > BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
> > mask for PCIEPAMR register". Can the issue fixed by this patch happen with
> > the current driver in host mode, or is that limited to ep mode?
> > In case of the former, please submit it to the PCI maintainer as a separate
> > fix.
>
> Thank you for pointed it out. I think this is the case of the former.
> IIUC, if such a small window PCIe device exists, the issue happens.
>
> Prabhakar-san, is my understanding correct?
>
This issue will only be hit on EP, when in host mode the sizes will be fixed to 1 Mbytes /2 Mbytes /128 Mbytes

Cheers,
--Prabhakar

> Best regards,
> Yoshihiro Shimoda



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
Yoshihiro Shimoda April 3, 2020, 9:44 a.m. UTC | #5
Hi Prabhakar-san,

> From: Prabhakar Mahadev Lad, Sent: Friday, April 3, 2020 6:32 PM
<snip>
> > > BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
> > > mask for PCIEPAMR register". Can the issue fixed by this patch happen with
> > > the current driver in host mode, or is that limited to ep mode?
> > > In case of the former, please submit it to the PCI maintainer as a separate
> > > fix.
> >
> > Thank you for pointed it out. I think this is the case of the former.
> > IIUC, if such a small window PCIe device exists, the issue happens.
> >
> > Prabhakar-san, is my understanding correct?
> >
> This issue will only be hit on EP, when in host mode the sizes will be fixed to 1 Mbytes /2 Mbytes /128 Mbytes

Thank you for your comment. Now I understood this is related to "PCIEn memory m" in the document
and related to ranges property in the device node. So, I'd like to recall my previous comment and
I agree the patch 06/11 is required on EP mode only.

Best regards,
Yoshihiro Shimoda

Patch
diff mbox series

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 24e534d85045..97575f9a91e2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -192,7 +192,7 @@  CONFIG_HOTPLUG_PCI=y
 CONFIG_HOTPLUG_PCI_ACPI=y
 CONFIG_PCI_AARDVARK=y
 CONFIG_PCI_TEGRA=y
-CONFIG_PCIE_RCAR=y
+CONFIG_PCIE_RCAR_HOST=y
 CONFIG_PCI_HOST_GENERIC=y
 CONFIG_PCI_XGENE=y
 CONFIG_PCIE_ALTERA=y