| Message ID | 20200403013541.20904-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM:zx:Delete duplicate dev_err message in zx296702_pd_probe() | expand |
> In this place,devm_ioremap_resource() has already contains error > message, so delete the duplicate dev_err message. Please fix such a commit message. * I find an other wording more appropriate. * It seems that you stumble on challenges to add space characters (after double colons or commas). * This is another attempt for the previous update suggestion “ARM:mach-zx：remove duplicate debug message”. https://lore.kernel.org/patchwork/patch/1203764/ https://lore.kernel.org/linux-arm-kernel/20200303031725.14560-1-tangbin@cmss.chinamobile.com/ > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> I find this tag interesting in a specific way. Will the use of your real name trigger any more consequences also on other patches? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=bef7b2a7be28638770972ab2709adf11d601c11a#n458 How do you think about to change any more source files in a systematic way? Regards, Markus
diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index 7a08bf9dd..ac44ea8e6 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c +++ b/arch/arm/mach-zx/zx296702-pm-domain.c @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev) } pcubase = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pcubase)) { - dev_err(&pdev->dev, "ioremap fail.\n"); + if (IS_ERR(pcubase)) return -EIO; - } for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) pm_genpd_init(zx296702_pm_domains[i], NULL, false);
In this place,devm_ioremap_resource() has already contains error message, so delete the duplicate dev_err message. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- arch/arm/mach-zx/zx296702-pm-domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)