[v2,3/3] watchdog: da9062: No need to ping manually before setting timeout
diff mbox series

Message ID 20200403130728.39260-3-s.riedmueller@phytec.de
State Accepted
Headers show
  • [v2,1/3] watchdog: da9062: Initialize timeout during probe
Related show

Commit Message

Stefan Riedmueller April 3, 2020, 1:07 p.m. UTC
There is actually no need to ping the watchdog before disabling it
during timeout change. Disabling the watchdog already takes care of
resetting the counter.

This fixes an issue during boot when the userspace watchdog handler takes
over and the watchdog is already running. Opening the watchdog in this case
leads to the first ping and directly after that without the required
heartbeat delay a second ping issued by the set_timeout call. Due to the
missing delay this resulted in a reset.

Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Changes in v2:
 - Added Reviewed-by tags.
 drivers/watchdog/da9062_wdt.c | 5 -----
 1 file changed, 5 deletions(-)

diff mbox series

diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
index 10b37dd65bed..706fb09c2f24 100644
--- a/drivers/watchdog/da9062_wdt.c
+++ b/drivers/watchdog/da9062_wdt.c
@@ -67,11 +67,6 @@  static int da9062_wdt_update_timeout_register(struct da9062_watchdog *wdt,
 					      unsigned int regval)
 	struct da9062 *chip = wdt->hw;
-	int ret;
-	ret = da9062_reset_watchdog_timer(wdt);
-	if (ret)
-		return ret;