From patchwork Fri Apr 3 13:58:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11472781 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1D8E91805 for ; Fri, 3 Apr 2020 13:59:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF66F2077D for ; Fri, 3 Apr 2020 13:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="dWvuqheK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF66F2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A294E6EBBE; Fri, 3 Apr 2020 13:59:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id A76A26EBCB for ; Fri, 3 Apr 2020 13:58:59 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id j17so8571721wru.13 for ; Fri, 03 Apr 2020 06:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=otIrhwZjoFpvWNzNejn5R22CMdP0/kgQJt8widdx7Ho=; b=dWvuqheKmGOa21IayDbnPnK4nPH1vpdeovUtpDXD0mM5n7uFIAK+7x762lQZDKyM4Y 9I4DM8oYVYglevu7qB170Jy0zqqCgNqVsDqD9eDONwZnq4t7KKgSTwAhGZUFxcuI1av2 8SVyFn60lDzyz059rDf+/YSwq2UJy4kp9gcts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=otIrhwZjoFpvWNzNejn5R22CMdP0/kgQJt8widdx7Ho=; b=X4d4M8jTa7OLsV0oKlzVYOJZWVR3CKz/+eYKRi6Yp5CGt2Q6LvtcfmLRK0184B57O1 731dw1+dDoWeXSs+yRu7AU073P3StEjD1C4Qn+Xpx+Uo6VQrqpHYcYWbugjeMgiwMi1K vbttFFio8HFd9d2VROmRY+xGavp6ux/6esLTVGc+lumxjQp+pJPt+YdCYHxJL3pL6em1 c5f/4CDsga3r68z3JPfjvjhJRW80ebBLLdjtxvbFBCXMeSLn5JtKSpWnQXyZAgpSIQ2f oXDdjS7iRNBnD/tfHjMIFXUJ1uv1CPRcB4ndAjjcg6irVZVj4AinKpn9ONFz5Xs3yVPk I/tg== X-Gm-Message-State: AGi0PuZ6aA0f50G4OXW/yHR9ldMQgwyLoxIvJ044b6jq7MgBUDoYzRVk 7XVzZrhRi5UDGdK9MIuL0XqXPrZA452toQ== X-Google-Smtp-Source: APiQypKW65YqGixRuX3K90+2HCF1vQh4514XACGmSsIVKNhsrbSsR4h+PQWdvpZISH0CcxNM3nDa4g== X-Received: by 2002:adf:f1c4:: with SMTP id z4mr9773093wro.342.1585922338038; Fri, 03 Apr 2020 06:58:58 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f141sm11783919wmf.3.2020.04.03.06.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 06:58:57 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 20/44] drm/mi0283qt: Use devm_drm_dev_alloc Date: Fri, 3 Apr 2020 15:58:04 +0200 Message-Id: <20200403135828.2542770-21-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200403135828.2542770-1-daniel.vetter@ffwll.ch> References: <20200403135828.2542770-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Already using devm_drm_dev_init, so very simple replacment. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/tiny/mi0283qt.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c index decaf57053ff..08ac549ab0f7 100644 --- a/drivers/gpu/drm/tiny/mi0283qt.c +++ b/drivers/gpu/drm/tiny/mi0283qt.c @@ -187,18 +187,13 @@ static int mi0283qt_probe(struct spi_device *spi) u32 rotation = 0; int ret; - dbidev = kzalloc(sizeof(*dbidev), GFP_KERNEL); - if (!dbidev) - return -ENOMEM; + dbidev = devm_drm_dev_alloc(dev, &mi0283qt_driver, + struct mipi_dbi_dev, drm); + if (IS_ERR(dbidev)) + return PTR_ERR(dbidev); dbi = &dbidev->dbi; drm = &dbidev->drm; - ret = devm_drm_dev_init(dev, drm, &mi0283qt_driver); - if (ret) { - kfree(dbidev); - return ret; - } - drmm_add_final_kfree(drm, dbidev); dbi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(dbi->reset)) {