| Message ID | 20200405170904.61512-2-stephan@gerhold.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] Input: mms114 - add support for mms345l | expand |
Hi Stephan, On Sun, Apr 05, 2020 at 07:09:04PM +0200, Stephan Gerhold wrote: > The mms114 driver now supports MMS345L; document the > melfas,mms345l binding that is used for it. > > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Andi Shyti <andi@etezian.org> > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> just one nitpick, the signing should be sorted in chronological order, I see that you reverted it. You first signed it as the author, then I reviewed it and the Rob acked it, so that it should be: Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Andi Shyti <andi@etezian.org> Acked-by: Rob Herring <robh@kernel.org> you reversed it. Other than that, I'm sorry I couldn't help you but I haven't received answers from Samsung about getting the prototypes. However I don't see reason for not applying the patch. Andi
On Wed, Apr 08, 2020 at 12:51:43AM +0300, Andi Shyti wrote: > Hi Stephan, > > On Sun, Apr 05, 2020 at 07:09:04PM +0200, Stephan Gerhold wrote: > > The mms114 driver now supports MMS345L; document the > > melfas,mms345l binding that is used for it. > > > > Acked-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Andi Shyti <andi@etezian.org> > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > > just one nitpick, the signing should be sorted in chronological > order, I see that you reverted it. > > You first signed it as the author, then I reviewed it and the Rob > acked it, so that it should be: > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > Reviewed-by: Andi Shyti <andi@etezian.org> > Acked-by: Rob Herring <robh@kernel.org> > > you reversed it. > I didn't really "reverse" it, I didn't know the order of these tags is important at all. :) Is this documented somewhere? Since I have added the tags and re-sent the patch, I thought it would make sense have my Signed-off-by last. I suppose this can be easily fixed up if Dmitry wants to apply the patch. But if I should re-send with the order changed in some way, just let me know. :) > Other than that, I'm sorry I couldn't help you but I haven't > received answers from Samsung about getting the prototypes. > However I don't see reason for not applying the patch. It's fine, don't worry :) I just think at this point we should either take my patch (and preserve existing behavior for all currently supported devices), or accept the potential breakage when refactoring the driver (because seemingly no-one is able to test it on the other versions at the moment). Thanks, Stephan
diff --git a/Documentation/devicetree/bindings/input/touchscreen/mms114.txt b/Documentation/devicetree/bindings/input/touchscreen/mms114.txt index 2cd954051d29..707234cfd7e6 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/mms114.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/mms114.txt @@ -1,9 +1,10 @@ -* MELFAS MMS114/MMS152 touchscreen controller +* MELFAS MMS114/MMS152/MMS345L touchscreen controller Required properties: - compatible: should be one of: - "melfas,mms114" - "melfas,mms152" + - "melfas,mms345l" - reg: I2C address of the chip - interrupts: interrupt to which the chip is connected - touchscreen-size-x: See [1]