From patchwork Mon Apr 6 15:35:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 11475707 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8060B913 for ; Mon, 6 Apr 2020 15:35:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6934F248A0 for ; Mon, 6 Apr 2020 15:35:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6934F248A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 448436E40F; Mon, 6 Apr 2020 15:35:43 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81AD16E40F; Mon, 6 Apr 2020 15:35:41 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 20817864-1500050 for multiple; Mon, 06 Apr 2020 16:35:18 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Mon, 6 Apr 2020 16:35:18 +0100 Message-Id: <20200406153518.1642031-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] i915/i915_hangman: Drop last reference to bygone 'i915_error_state' X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The test is looking at sysfs/error so dumping the old debugfs/i915_error_state looks quite silly. The only dilemma is whether it is worth replacing with a line-by-line dump. I propose we make that a future problem -- and leave it to whoever has to debug it next time. Signed-off-by: Chris Wilson Reviewed-by: Andi Shyti --- lib/igt_aux.c | 1 - tests/i915/i915_hangman.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/igt_aux.c b/lib/igt_aux.c index 1a5648444..ecab5d998 100644 --- a/lib/igt_aux.c +++ b/lib/igt_aux.c @@ -484,7 +484,6 @@ hang_detector_process(int fd, pid_t pid, dev_t rdev) str = udev_device_get_property_value(dev, "ERROR"); if (str && atoi(str) == 1) { - igt_debugfs_dump(fd, "i915_error_state"); show_kernel_stack(pid); kill(pid, SIGIO); } diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c index 08b06217e..13cd62087 100644 --- a/tests/i915/i915_hangman.c +++ b/tests/i915/i915_hangman.c @@ -140,8 +140,6 @@ static void check_error_state(const char *expected_ring_name, size_t line_size = 0; bool found = false; - igt_debugfs_dump(device, "i915_error_state"); - igt_assert(getline(&line, &line_size, file) != -1); igt_require(strcasecmp(line, "No error state collected"));