| Message ID | 20200406134405.6232-4-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Set up generic fbdev after registering device | expand |
On Mon, Apr 06, 2020 at 03:43:58PM +0200, Thomas Zimmermann wrote: > Generic fbdev support is a DRM client. Set it up after fully registering > the new DRM device. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > index d3145ae877d74..981858cc8d2b5 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > @@ -277,8 +277,6 @@ static int kirin_drm_bind(struct device *dev) > if (ret) > goto err_kms_cleanup; > > - drm_fbdev_generic_setup(drm_dev, 32); > - > /* connectors should be registered after drm device register */ > if (driver_data->register_connects) { > ret = kirin_drm_connectors_register(drm_dev); > @@ -286,6 +284,8 @@ static int kirin_drm_bind(struct device *dev) > goto err_drm_dev_unregister; > } > > + drm_fbdev_generic_setup(drm_dev, 32); The code you jump over is nonsense and should be reverted. I replied to the patch that landed this. -Daniel > + > return 0; > > err_drm_dev_unregister: > -- > 2.26.0 >
Hi Am 07.04.20 um 10:04 schrieb Daniel Vetter: > On Mon, Apr 06, 2020 at 03:43:58PM +0200, Thomas Zimmermann wrote: >> Generic fbdev support is a DRM client. Set it up after fully registering >> the new DRM device. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> --- >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c >> index d3145ae877d74..981858cc8d2b5 100644 >> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c >> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c >> @@ -277,8 +277,6 @@ static int kirin_drm_bind(struct device *dev) >> if (ret) >> goto err_kms_cleanup; >> >> - drm_fbdev_generic_setup(drm_dev, 32); >> - >> /* connectors should be registered after drm device register */ >> if (driver_data->register_connects) { >> ret = kirin_drm_connectors_register(drm_dev); >> @@ -286,6 +284,8 @@ static int kirin_drm_bind(struct device *dev) >> goto err_drm_dev_unregister; >> } >> >> + drm_fbdev_generic_setup(drm_dev, 32); > > The code you jump over is nonsense and should be reverted. I replied to > the patch that landed this. What did they respond? When I read this code, I wondered why it might be there. Best regards Thomas > -Daniel > >> + >> return 0; >> >> err_drm_dev_unregister: >> -- >> 2.26.0 >> >
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c index d3145ae877d74..981858cc8d2b5 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c @@ -277,8 +277,6 @@ static int kirin_drm_bind(struct device *dev) if (ret) goto err_kms_cleanup; - drm_fbdev_generic_setup(drm_dev, 32); - /* connectors should be registered after drm device register */ if (driver_data->register_connects) { ret = kirin_drm_connectors_register(drm_dev); @@ -286,6 +284,8 @@ static int kirin_drm_bind(struct device *dev) goto err_drm_dev_unregister; } + drm_fbdev_generic_setup(drm_dev, 32); + return 0; err_drm_dev_unregister:
Generic fbdev support is a DRM client. Set it up after fully registering the new DRM device. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)