[5/5] xfs_scrub: fix type error in render_ino_from_handle
diff mbox series

Message ID 158619917550.469742.14501955862263559558.stgit@magnolia
State Accepted
Headers show
Series
  • xfsprogs: rollup of various fixes for 5.6
Related show

Commit Message

Darrick J. Wong April 6, 2020, 6:52 p.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

render_ino_from_handle is passed a struct xfs_bulkstat, not xfs_bstat.
Fix this.

Fixes: 4cca629d6ae3807 ("misc: convert xfrog_bulkstat functions to have v5 semantics")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 scrub/phase5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Allison Collins April 6, 2020, 10:09 p.m. UTC | #1
On 4/6/20 11:52 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> render_ino_from_handle is passed a struct xfs_bulkstat, not xfs_bstat.
> Fix this.
> 
> Fixes: 4cca629d6ae3807 ("misc: convert xfrog_bulkstat functions to have v5 semantics")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Ok, looks good
Reviewed-by: Allison Collins <allison.henderson@oracle.com>

> ---
>   scrub/phase5.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/scrub/phase5.c b/scrub/phase5.c
> index 540b840d..fcd5ba27 100644
> --- a/scrub/phase5.c
> +++ b/scrub/phase5.c
> @@ -242,7 +242,7 @@ render_ino_from_handle(
>   	size_t			buflen,
>   	void			*data)
>   {
> -	struct xfs_bstat	*bstat = data;
> +	struct xfs_bulkstat	*bstat = data;
>   
>   	return scrub_render_ino_descr(ctx, buf, buflen, bstat->bs_ino,
>   			bstat->bs_gen, NULL);
>
Christoph Hellwig April 9, 2020, 7:44 a.m. UTC | #2
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch
diff mbox series

diff --git a/scrub/phase5.c b/scrub/phase5.c
index 540b840d..fcd5ba27 100644
--- a/scrub/phase5.c
+++ b/scrub/phase5.c
@@ -242,7 +242,7 @@  render_ino_from_handle(
 	size_t			buflen,
 	void			*data)
 {
-	struct xfs_bstat	*bstat = data;
+	struct xfs_bulkstat	*bstat = data;
 
 	return scrub_render_ino_descr(ctx, buf, buflen, bstat->bs_ino,
 			bstat->bs_gen, NULL);