diff mbox

[1/2] ARM: imx6q-sabrelite.dts: Add watchdog support

Message ID 1341258627-3469-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam July 2, 2012, 7:50 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Add watchdog support.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Comments

Shawn Guo July 3, 2012, 3:03 a.m. UTC | #1 
On Mon, Jul 02, 2012 at 04:50:26PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add watchdog support.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
> index e0ec929..99581a0 100644
> --- a/arch/arm/boot/dts/imx6q-sabrelite.dts
> +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
> @@ -42,6 +42,9 @@
>  				};
>  			};
>  
> +			wdog@020bc000 { /* WDOG1 */
> +				status = "okay";
> +			};

I'm wondering if it makes more sense to have wdog, rtc, such completely
soc internal stuff always enabled in <soc>.dtsi.

>  		};
>  
>  		aips-bus@02100000 { /* AIPS2 */
> -- 
> 1.7.1
>
Sascha Hauer July 3, 2012, 10:17 a.m. UTC | #2 
On Tue, Jul 03, 2012 at 11:03:39AM +0800, Shawn Guo wrote:
> On Mon, Jul 02, 2012 at 04:50:26PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Add watchdog support.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >  arch/arm/boot/dts/imx6q-sabrelite.dts |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
> > index e0ec929..99581a0 100644
> > --- a/arch/arm/boot/dts/imx6q-sabrelite.dts
> > +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
> > @@ -42,6 +42,9 @@
> >  				};
> >  			};
> >  
> > +			wdog@020bc000 { /* WDOG1 */
> > +				status = "okay";
> > +			};
> 
> I'm wondering if it makes more sense to have wdog, rtc, such completely
> soc internal stuff always enabled in <soc>.dtsi.

+1 for the watchdog

I'm not so sure about the rtc though, since one important component of
the RTC is not completely internal to the SoC: the battery.

Sascha
Shawn Guo July 3, 2012, 10:39 a.m. UTC | #3 
On 3 July 2012 18:17, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> I'm not so sure about the rtc though, since one important component of
> the RTC is not completely internal to the SoC: the battery.
>
Yes, that the case, practically.  But technically, even without
battery, RTC can also be useful for a system if only warm reset will
be performed.

Regards,
Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index e0ec929..99581a0 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -42,6 +42,9 @@ 
 				};
 			};
 
+			wdog@020bc000 { /* WDOG1 */
+				status = "okay";
+			};
 		};
 
 		aips-bus@02100000 { /* AIPS2 */