[091/166] mm/dmapool.c: micro-optimisation remove unnecessary branch
diff mbox series

Message ID 20200407030849.9Yx9nrR8r%akpm@linux-foundation.org
State New
Headers show
  • [001/166] mm, memcg: bypass high reclaim iteration for cgroup hierarchy root
Related show

Commit Message

Andrew Morton April 7, 2020, 3:08 a.m. UTC
From: Mateusz Nosek <mateusznosek0@gmail.com>
Subject: mm/dmapool.c: micro-optimisation remove unnecessary branch

Previously there was a check if 'size' is aligned to 'align' and if not
then it was aligned.  This check was expensive as both branch and division
are expensive instructions in most architectures.  'ALIGN' function on
already aligned value will not change it, and as it is cheaper than branch
+ division it can be executed all the time and branch can be removed.

Link: http://lkml.kernel.org/r/20200320173317.26408-1-mateusznosek0@gmail.com
Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

 mm/dmapool.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff mbox series

--- a/mm/dmapool.c~mm-dmapoolc-micro-optimisation-remove-unnecessary-branch
+++ a/mm/dmapool.c
@@ -144,9 +144,7 @@  struct dma_pool *dma_pool_create(const c
 	else if (size < 4)
 		size = 4;
-	if ((size % align) != 0)
-		size = ALIGN(size, align);
+	size = ALIGN(size, align);
 	allocation = max_t(size_t, size, PAGE_SIZE);
 	if (!boundary)