Message ID | 20200407142243.2032-3-mk@cm4all.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v3,1/4] fs/posix_acl: apply umask if superblock disables ACL support | expand |
> +#ifdef CONFIG_FS_POSIX_ACL > #define IS_POSIXACL(inode) __IS_FLG(inode, SB_POSIXACL) > +#else > +#define IS_POSIXACL(inode) 0 > +#endif Looks good, but I'd simplify this down to: #define IS_POSIXACL(inode) \ (IS_ENABLED(CONFIG_FS_POSIX_ACL) && __IS_FLG(inode, SB_POSIXACL))
diff --git a/include/linux/fs.h b/include/linux/fs.h index abedbffe2c9e..5721be1146b1 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2027,7 +2027,12 @@ static inline bool sb_rdonly(const struct super_block *sb) { return sb->s_flags #define IS_NOQUOTA(inode) ((inode)->i_flags & S_NOQUOTA) #define IS_APPEND(inode) ((inode)->i_flags & S_APPEND) #define IS_IMMUTABLE(inode) ((inode)->i_flags & S_IMMUTABLE) + +#ifdef CONFIG_FS_POSIX_ACL #define IS_POSIXACL(inode) __IS_FLG(inode, SB_POSIXACL) +#else +#define IS_POSIXACL(inode) 0 +#endif #define IS_DEADDIR(inode) ((inode)->i_flags & S_DEAD) #define IS_NOCMTIME(inode) ((inode)->i_flags & S_NOCMTIME)