drm/i915/selftests: Drop vestigal timeslicing assert
diff mbox series

Message ID 20200407222625.15542-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/selftests: Drop vestigal timeslicing assert
Related show

Commit Message

Chris Wilson April 7, 2020, 10:26 p.m. UTC
Since the semaphore interrupt may cause us to yield the timeslice
immediately, we may cancel the timer before we notice the submission is
complete. The assertion is no longer valid due to the race with the
interrupt.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tvrtko Ursulin April 8, 2020, 7:58 a.m. UTC | #1
On 07/04/2020 23:26, Chris Wilson wrote:
> Since the semaphore interrupt may cause us to yield the timeslice
> immediately, we may cancel the timer before we notice the submission is
> complete. The assertion is no longer valid due to the race with the
> interrupt.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_lrc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index 43362b8a5855..57db3d0ffaf2 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -1073,7 +1073,6 @@ static int live_timeslice_rewind(void *arg)
>   			       engine->name);
>   			goto err;
>   		}
> -		GEM_BUG_ON(!timer_pending(&engine->execlists.timer));
>   
>   		/* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */
>   		if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 43362b8a5855..57db3d0ffaf2 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -1073,7 +1073,6 @@  static int live_timeslice_rewind(void *arg)
 			       engine->name);
 			goto err;
 		}
-		GEM_BUG_ON(!timer_pending(&engine->execlists.timer));
 
 		/* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */
 		if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */