| Message ID | 20200408190606.870098-2-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] ath11k: fix missing return in ath11k_thermal_set_throttling | expand |
Arnd Bergmann <arnd@arndb.de> writes: > The stub function has the wrong prototype, causing a warning: > > drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy': > drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] > > Change it to take the same arguments as the normal implementation. > > Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/wireless/ath/ath11k/thermal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h > index f1395a14748c..ea9a58bf6a93 100644 > --- a/drivers/net/wireless/ath/ath11k/thermal.h > +++ b/drivers/net/wireless/ath/ath11k/thermal.h > @@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc) > return 0; > } > > -static inline void ath11k_thermal_unregister(struct ath11k *ar) > +static inline void ath11k_thermal_unregister(struct ath11k_base *ar) > { > } Already fixed by this commit: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=c9be1a642a7b9ec021e3f32e084dc781b3e5216d
diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h index f1395a14748c..ea9a58bf6a93 100644 --- a/drivers/net/wireless/ath/ath11k/thermal.h +++ b/drivers/net/wireless/ath/ath11k/thermal.h @@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc) return 0; } -static inline void ath11k_thermal_unregister(struct ath11k *ar) +static inline void ath11k_thermal_unregister(struct ath11k_base *ar) { }
The stub function has the wrong prototype, causing a warning: drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy': drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] Change it to take the same arguments as the normal implementation. Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/ath/ath11k/thermal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)