xfs: remove unnecessary assertion from xfs_qm_vop_create_dqattach
diff mbox series

Message ID 1586489141-4708-1-git-send-email-kaixuxia@tencent.com
State Superseded
Headers show
  • xfs: remove unnecessary assertion from xfs_qm_vop_create_dqattach
Related show

Commit Message

kaixuxia April 10, 2020, 3:25 a.m. UTC
From: Kaixu Xia <kaixuxia@tencent.com>

The check XFS_IS_QUOTA_RUNNING() has been done when enter the
xfs_qm_vop_create_dqattach() function, it will return directly
if the result is false, so maybe the followed XFS_IS_QUOTA_RUNNING()
assertion is unnecessary. If we truly care about this, the check also
can be added to the next if statements.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
 fs/xfs/xfs_qm.c | 1 -
 1 file changed, 1 deletion(-)

diff mbox series

diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index b684b04..fc93f88 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -1932,7 +1932,6 @@  struct xfs_dquot *
 	ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
 	if (udqp && XFS_IS_UQUOTA_ON(mp)) {
 		ASSERT(ip->i_udquot == NULL);