diff mbox series

[32/35] drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings

Message ID 20200410213403.Hq3FxdN1e%akpm@linux-foundation.org (mailing list archive)
State New, archived
Headers show
Series [01/35] hfsplus: fix crash and filesystem corruption when deleting files | expand

Commit Message

Andrew Morton April 10, 2020, 9:34 p.m. UTC 
From: kbuild test robot <lkp@intel.com>
Subject: drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings

Remove dev_err() messages after platform_get_irq*() failures. 
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Link: http://lkml.kernel.org/r/alpine.DEB.2.21.2002271133450.2973@hadrien
Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Vinod Koul <vinod.koul@linux.intel.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/dma/tegra20-apb-dma.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Jon Hunter April 13, 2020, 5:54 p.m. UTC | #1 
On 10/04/2020 22:34, Andrew Morton wrote:
> From: kbuild test robot <lkp@intel.com>
> Subject: drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings
> 
> Remove dev_err() messages after platform_get_irq*() failures. 
> platform_get_irq() already prints an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Link: http://lkml.kernel.org/r/alpine.DEB.2.21.2002271133450.2973@hadrien
> Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Vinod Koul <vinod.koul@linux.intel.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/dma/tegra20-apb-dma.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/dma/tegra20-apb-dma.c~dmaengine-tegra-apb-fix-platform_get_irqcocci-warnings
> +++ a/drivers/dma/tegra20-apb-dma.c
> @@ -1493,7 +1493,6 @@ static int tegra_dma_probe(struct platfo
>  		irq = platform_get_irq(pdev, i);
>  		if (irq < 0) {
>  			ret = irq;
> -			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
>  			goto err_pm_disable;
>  		}
>  

Thanks!

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon
diff mbox series

Patch

--- a/drivers/dma/tegra20-apb-dma.c~dmaengine-tegra-apb-fix-platform_get_irqcocci-warnings
+++ a/drivers/dma/tegra20-apb-dma.c
@@ -1493,7 +1493,6 @@  static int tegra_dma_probe(struct platfo
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
 			ret = irq;
-			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
 			goto err_pm_disable;
 		}