| Message ID | 20200413082043.22468-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7b9ae69d5441d98ce55da7d651efff2c7ce27551 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | orinoco: remove useless variable 'err' in spectrum_cs_suspend() | expand |
Jason Yan <yanaijie@huawei.com> wrote: > Fix the following coccicheck warning: > > drivers/net/wireless/intersil/orinoco/spectrum_cs.c:281:5-8: Unneeded > variable: "err". Return "0" on line 286 > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 7b9ae69d5441 orinoco: remove useless variable 'err' in spectrum_cs_suspend()
diff --git a/drivers/net/wireless/intersil/orinoco/spectrum_cs.c b/drivers/net/wireless/intersil/orinoco/spectrum_cs.c index b60048c95e0a..291ef97ed45e 100644 --- a/drivers/net/wireless/intersil/orinoco/spectrum_cs.c +++ b/drivers/net/wireless/intersil/orinoco/spectrum_cs.c @@ -278,12 +278,11 @@ static int spectrum_cs_suspend(struct pcmcia_device *link) { struct orinoco_private *priv = link->priv; - int err = 0; /* Mark the device as stopped, to block IO until later */ orinoco_down(priv); - return err; + return 0; } static int
Fix the following coccicheck warning: drivers/net/wireless/intersil/orinoco/spectrum_cs.c:281:5-8: Unneeded variable: "err". Return "0" on line 286 Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/wireless/intersil/orinoco/spectrum_cs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)