kbuild: arch/$(SUBARCH)/include/generated/ aren't cleaned by mrproper
diff mbox series

Message ID 20200413115815.141587-1-vitor@massaru.org
State New
Headers show
Series
  • kbuild: arch/$(SUBARCH)/include/generated/ aren't cleaned by mrproper
Related show

Commit Message

Vitor Massaru Iha April 13, 2020, 11:58 a.m. UTC
This bug was introduced in this commit a788b2ed81abe

Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205219

Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Brendan Higgins April 13, 2020, 7:47 p.m. UTC | #1
On Mon, Apr 13, 2020 at 4:58 AM Vitor Massaru Iha <vitor@massaru.org> wrote:
>
> This bug was introduced in this commit a788b2ed81abe
>
> Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205219
>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>

Please elaborate on what this change does and why it is necessary.
Shuah and I are not the only ones who will want to understand what is
going on here.

Otherwise, the change itself looks good to me.

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
Vitor Massaru Iha April 13, 2020, 8:09 p.m. UTC | #2
On Mon, 2020-04-13 at 12:47 -0700, Brendan Higgins wrote:
> On Mon, Apr 13, 2020 at 4:58 AM Vitor Massaru Iha <vitor@massaru.org>
> wrote:
> > This bug was introduced in this commit a788b2ed81abe
> > 
> > Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205219
> > 
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> 
> Please elaborate on what this change does and why it is necessary.
> Shuah and I are not the only ones who will want to understand what is
> going on here.

Sure, I'll do that.

Thanks for the review.

> 
> Otherwise, the change itself looks good to me.
> 
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Tested-by: Brendan Higgins <brendanhiggins@google.com>

Patch
diff mbox series

diff --git a/Makefile b/Makefile
index 70def4907036..e1a79796032e 100644
--- a/Makefile
+++ b/Makefile
@@ -532,7 +532,8 @@  outputmakefile:
 ifdef building_out_of_srctree
 	$(Q)if [ -f $(srctree)/.config -o \
 		 -d $(srctree)/include/config -o \
-		 -d $(srctree)/arch/$(SRCARCH)/include/generated ]; then \
+		 -d $(srctree)/arch/$(SRCARCH)/include/generated -o \
+		 -d $(srctree)/arch/$(SUBARCH)/include/generated ]; then \
 		echo >&2 "***"; \
 		echo >&2 "*** The source tree is not clean, please run 'make$(if $(findstring command line, $(origin ARCH)), ARCH=$(ARCH)) mrproper'"; \
 		echo >&2 "*** in $(abs_srctree)";\
@@ -1388,6 +1389,7 @@  CLEAN_FILES += modules.builtin modules.builtin.modinfo modules.nsdeps
 # Directories & files removed with 'make mrproper'
 MRPROPER_DIRS  += include/config include/generated          \
 		  arch/$(SRCARCH)/include/generated .tmp_objdiff \
+		  arch/$(SUBARCH)/include/generated \
 		  debian/ snap/ tar-install/
 MRPROPER_FILES += .config .config.old .version \
 		  Module.symvers \