| Message ID | 20200415074034.175360-59-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | devm_drm_dev_alloc, v2 | expand |
Am 15.04.20 um 09:40 schrieb Daniel Vetter: > This is only needed for hotpluggable connectors set up after > drm_dev_register(). > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Thomas Zimemrmann <tzimmermann@suse.de> > --- > drivers/gpu/drm/ast/ast_mode.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > index cdd6c46d6557..84b1d1fea41f 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -1069,7 +1069,6 @@ static void ast_connector_destroy(struct drm_connector *connector) > { > struct ast_connector *ast_connector = to_ast_connector(connector); > ast_i2c_destroy(ast_connector->i2c); > - drm_connector_unregister(connector); > drm_connector_cleanup(connector); > kfree(connector); > } > @@ -1112,8 +1111,6 @@ static int ast_connector_init(struct drm_device *dev) > connector->interlace_allowed = 0; > connector->doublescan_allowed = 0; > > - drm_connector_register(connector); > - > connector->polled = DRM_CONNECTOR_POLL_CONNECT; > > encoder = list_first_entry(&dev->mode_config.encoder_list, struct drm_encoder, head); >
On Wed, Apr 15, 2020 at 09:40:33AM +0200, Daniel Vetter wrote: > This is only needed for hotpluggable connectors set up after > drm_dev_register(). > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Emil Velikov <emil.velikov@collabora.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/ast/ast_mode.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c > index cdd6c46d6557..84b1d1fea41f 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -1069,7 +1069,6 @@ static void ast_connector_destroy(struct drm_connector *connector) > { > struct ast_connector *ast_connector = to_ast_connector(connector); > ast_i2c_destroy(ast_connector->i2c); > - drm_connector_unregister(connector); > drm_connector_cleanup(connector); > kfree(connector); > } > @@ -1112,8 +1111,6 @@ static int ast_connector_init(struct drm_device *dev) > connector->interlace_allowed = 0; > connector->doublescan_allowed = 0; > > - drm_connector_register(connector); > - > connector->polled = DRM_CONNECTOR_POLL_CONNECT; > > encoder = list_first_entry(&dev->mode_config.encoder_list, struct drm_encoder, head); > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index cdd6c46d6557..84b1d1fea41f 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -1069,7 +1069,6 @@ static void ast_connector_destroy(struct drm_connector *connector) { struct ast_connector *ast_connector = to_ast_connector(connector); ast_i2c_destroy(ast_connector->i2c); - drm_connector_unregister(connector); drm_connector_cleanup(connector); kfree(connector); } @@ -1112,8 +1111,6 @@ static int ast_connector_init(struct drm_device *dev) connector->interlace_allowed = 0; connector->doublescan_allowed = 0; - drm_connector_register(connector); - connector->polled = DRM_CONNECTOR_POLL_CONNECT; encoder = list_first_entry(&dev->mode_config.encoder_list, struct drm_encoder, head);
This is only needed for hotpluggable connectors set up after drm_dev_register(). Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Dave Airlie <airlied@redhat.com> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Emil Velikov <emil.velikov@collabora.com> --- drivers/gpu/drm/ast/ast_mode.c | 3 --- 1 file changed, 3 deletions(-)