diff mbox series

drm/panel: panel-simple: Set AUO G101EVN010 panel type

Message ID 20200417114043.25381-1-tomi.valkeinen@ti.com (mailing list archive)
State New, archived
Headers show
Series drm/panel: panel-simple: Set AUO G101EVN010 panel type | expand

Commit Message

Tomi Valkeinen April 17, 2020, 11:40 a.m. UTC
The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
indicated by the current bus_format.

Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
connector_type to LVDS.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Tomi Valkeinen April 17, 2020, 1 p.m. UTC | #1
(Adding Alex to the thread)

On 17/04/2020 14:40, Tomi Valkeinen wrote:
> The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> indicated by the current bus_format.
> 
> Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> connector_type to LVDS.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..bf781e260fe7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
>   		.width = 216,
>   		.height = 135,
>   	},
> -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>   };
>   
>   static const struct drm_display_mode auo_g104sn02_mode = {
>
Laurent Pinchart April 17, 2020, 1:10 p.m. UTC | #2
Hi Tomi,

Thank you for the patch.

On Fri, Apr 17, 2020 at 04:00:34PM +0300, Tomi Valkeinen wrote:
> (Adding Alex to the thread)
> 
> On 17/04/2020 14:40, Tomi Valkeinen wrote:
> > The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> > indicated by the current bus_format.
> > 
> > Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> > connector_type to LVDS.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

I'll trust you on the format,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >   drivers/gpu/drm/panel/panel-simple.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..bf781e260fe7 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
> >   		.width = 216,
> >   		.height = 135,
> >   	},
> > -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> >   };
> >   
> >   static const struct drm_display_mode auo_g104sn02_mode = {
Sam Ravnborg May 4, 2020, 7:46 p.m. UTC | #3
Hi Tomi.

On Fri, Apr 17, 2020 at 02:40:43PM +0300, Tomi Valkeinen wrote:
> The AUO G101EVN010 is a 18-bit LVDS panel, not a parallel panel, as
> indicated by the current bus_format.
> 
> Fix the bus_format to MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, and also set the
> connector_type to LVDS.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Updated subject a little and applied.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eaefe1..bf781e260fe7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -836,7 +836,8 @@ static const struct panel_desc auo_g101evn010 = {
>  		.width = 216,
>  		.height = 135,
>  	},
> -	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
>  static const struct drm_display_mode auo_g104sn02_mode = {
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ad828eaefe1..bf781e260fe7 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -836,7 +836,8 @@  static const struct panel_desc auo_g101evn010 = {
 		.width = 216,
 		.height = 135,
 	},
-	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct drm_display_mode auo_g104sn02_mode = {