| Message ID | 20200420134800.31604-2-benjamin.gaignard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | STM32 ETZPC bus controller | expand |
Hi Benjamin, On Mon, Apr 20, 2020 at 3:48 PM Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > Add schemas for firewall consumer and provider. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Bus Firewall consumer binding > + > +maintainers: > + - Benjamin Gaignard <benjamin.gaignard@st.com> This really needs a description: to tell what is going on and what these firewalls are for and how they are supposed to work. I suppose just a bit of cut'n'paste from the cover letter :D Otherwise it looks good to me. Yours, Linus Walleij
On 4/28/20 1:24 PM, Linus Walleij wrote: > Hi Benjamin, > > On Mon, Apr 20, 2020 at 3:48 PM Benjamin Gaignard > <benjamin.gaignard@st.com> wrote: >> Add schemas for firewall consumer and provider. >> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> >> +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Common Bus Firewall consumer binding >> + >> +maintainers: >> + - Benjamin Gaignard <benjamin.gaignard@st.com> > This really needs a description: to tell what is going on and what > these firewalls > are for and how they are supposed to work. Hi Linus, Does the following description sound good for you: Firewall properties provide the possible firewall bus controller configurations for a device. Bus firewall controllers are typically used to control if a hardware block can perform read or write operations on bus. The contents of the firewall bus configuration properties are defined by the binding for the individual firewall controller device. The first configuration 'firewall-0' or the one named 'default' is applied before probing the device itself. Regards, Benjamin > > I suppose just a bit of cut'n'paste from the cover letter :D > > Otherwise it looks good to me. > > Yours, > Linus Walleij
On Tue, Apr 28, 2020 at 3:13 PM Benjamin GAIGNARD <benjamin.gaignard@st.com> wrote: > Does the following description sound good for you: > Firewall properties provide the possible firewall bus controller > configurations for a device. > Bus firewall controllers are typically used to control if a hardware > block can perform read or write operations on bus. > The contents of the firewall bus configuration properties are defined by > the binding for the individual firewall controller device. > The first configuration 'firewall-0' or the one named 'default' is > applied before probing the device itself. Looks good to me! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> with this added. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml new file mode 100644 index 000000000000..8f123888d058 --- /dev/null +++ b/Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml @@ -0,0 +1,25 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Common Bus Firewall consumer binding + +maintainers: + - Benjamin Gaignard <benjamin.gaignard@st.com> + +# always select the core schema +select: true + +properties: + firewall-0: true + + firewall-names: true + +patternProperties: + "firewall-[0-9]": + $ref: "/schemas/types.yaml#/definitions/phandle-array" + +dependencies: + firewall-names: [ firewall-0 ] diff --git a/Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml b/Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml new file mode 100644 index 000000000000..299824c620ea --- /dev/null +++ b/Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml @@ -0,0 +1,18 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bus/stm32/firewall-provider.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Common Bus Firewall provider binding + +maintainers: + - Benjamin Gaignard <benjamin.gaignard@st.com> + +properties: + '#firewall-cells': + $ref: /schemas/types.yaml#/definitions/uint32 + description: Number of cells in a bus firewall specifier + +required: + - '#firewall-cells'
Add schemas for firewall consumer and provider. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- .../bindings/bus/stm32/firewall-consumer.yaml | 25 ++++++++++++++++++++++ .../bindings/bus/stm32/firewall-provider.yaml | 18 ++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-consumer.yaml create mode 100644 Documentation/devicetree/bindings/bus/stm32/firewall-provider.yaml