| Message ID | 1587412250-16752-2-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Pavel Machek |
| Headers | show |
| Series | Add HiHope RZ/G2M board with idk-1110wr display | expand |
Hi! > Add binding for the idk-1110wr LVDS panel from Advantech. > > Some panel-specific documentation can be found here: > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm > > This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0 > upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml > bindings. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Okay. In future, I believe we can take yaml binding, even for kernel where yaml support is not included. The markup is designed to be human-readable anyway. Best regards, Pavel
Hi Pavel, > -----Original Message----- > From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Pavel Machek via lists.cip-project.org > Sent: 20 April 2020 21:16 > To: cip-dev@lists.cip-project.org > Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Chris Paterson > <Chris.Paterson2@renesas.com> > Subject: Re: [cip-dev] [PATCH 1/2] dt-bindings: display: Add idk-1110wr binding > > Hi! > > > Add binding for the idk-1110wr LVDS panel from Advantech. > > > > Some panel-specific documentation can be found here: > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm > > > > This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0 > > upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml > > bindings. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Okay. In future, I believe we can take yaml binding, even for kernel > where yaml support is not included. The markup is designed to be > human-readable anyway. > Thanks I shall do that in future. Just for reference in case a yaml binding has a reference to other yaml binding so should there be a patch for converting to yaml format (for example panel.txt -> panel.yaml) ? Cheers, --Prabhakar > Best regards, > Pavel > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#4591): https://lists.cip-project.org/g/cip-dev/message/4591 Mute This Topic: https://lists.cip-project.org/mt/73158052/4520428 Group Owner: cip-dev+owner@lists.cip-project.org Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129116/1171672734/xyzzy [patchwork-cip-dev@patchwork.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi! > > > Add binding for the idk-1110wr LVDS panel from Advantech. > > > > > > Some panel-specific documentation can be found here: > > > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm > > > > > > This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0 > > > upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml > > > bindings. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Okay. In future, I believe we can take yaml binding, even for kernel > > where yaml support is not included. The markup is designed to be > > human-readable anyway. > > > Thanks I shall do that in future. Just for reference in case a yaml binding has a reference to other yaml binding so should there be a patch for converting to yaml format (for example panel.txt -> panel.yaml) ? > Goal here is to save work, and this is just a documentation, so no, I don't believe we need to do more conversions. Best regards, Pavel
diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt new file mode 100644 index 0000000..c5388b2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt @@ -0,0 +1,45 @@ +Advantech IDK-1110WR 10.1" WSVGA LVDS Display Panel +=================================================== + +The Advantech IDK-1110WR is a 10.1" industrial grade LCD display with +4-wire resistive touch. + +These DT bindings follow the LVDS panel bindings defined in panel-lvds.txt +with the following device-specific properties. + +Required properties: + +- compatible: Shall contain "advantech,idk-1110wr" and "panel-lvds", in that + order. + + +Example +------- + +panel { + compatible = "advantech,idk-1110wr", "panel-lvds"; + + width-mm = <223>; + height-mm = <125>; + + data-mapping = "jeida-24"; + + panel-timing { + /* 1024x600 @60Hz */ + clock-frequency = <51200000>; + hactive = <1024>; + vactive = <600>; + hsync-len = <240>; + hfront-porch = <40>; + hback-porch = <40>; + vsync-len = <10>; + vfront-porch = <15>; + vback-porch = <10>; + }; + + port { + panel_in: endpoint { + remote-endpoint = <&lvds_encoder>; + }; + }; +};
Add binding for the idk-1110wr LVDS panel from Advantech. Some panel-specific documentation can be found here: https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm This patch is based on commit d26087162857b12bd9d0424f2dea2cd9654e50a0 upstream ("dt-bindings: display: Add idk-1110wr binding") which adds yaml bindings. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../display/panel/advantech,idk-1110wr.txt | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.txt