| Message ID | 20200422150256.23473-2-jack@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm: Speedup page cache truncation | expand |
diff --git a/lib/xarray.c b/lib/xarray.c index e9e641d3c0c3..dae68dd13a02 100644 --- a/lib/xarray.c +++ b/lib/xarray.c @@ -803,13 +803,6 @@ void *xas_store(struct xa_state *xas, void *entry) xas_init_marks(xas); for (;;) { - /* - * Must clear the marks before setting the entry to NULL, - * otherwise xas_for_each_marked may find a NULL entry and - * stop early. rcu_assign_pointer contains a release barrier - * so the mark clearing will appear to happen before the - * entry is set to NULL. - */ rcu_assign_pointer(*slot, entry); if (xa_is_node(next) && (!node || node->shift)) xas_free_nodes(xas, xa_to_node(next));
Since commit 7e934cf5ace1 "xarray: Fix early termination of xas_for_each_marked" the comment is no longer relevant since xas_for_each_marked() can cope with marked NULL entries. Remove the comment. Signed-off-by: Jan Kara <jack@suse.cz> --- lib/xarray.c | 7 ------- 1 file changed, 7 deletions(-)