rtw88: fix sparse warnings for download firmware routine
diff mbox series

Message ID 20200424101255.28239-1-yhchuang@realtek.com
State Accepted
Commit 3d8bf50860c7de09c9713b97ec2f87ad42338c7e
Delegated to: Kalle Valo
Headers show
Series
  • rtw88: fix sparse warnings for download firmware routine
Related show

Commit Message

Tony Chuang April 24, 2020, 10:12 a.m. UTC
From: Yan-Hsuan Chuang <yhchuang@realtek.com>

sparse warnings: (new ones prefixed by >>)

>> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
symbol '__rtw_download_firmware' was not declared. Should it be static?
>> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
symbol '__rtw_download_firmware_legacy' was not declared. Should it be
static?

Fixes: 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/mac.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Kalle Valo April 28, 2020, 8:44 a.m. UTC | #1
<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
> symbol '__rtw_download_firmware' was not declared. Should it be static?
> >> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
> symbol '__rtw_download_firmware_legacy' was not declared. Should it be
> static?
> 
> Fixes: 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

3d8bf50860c7 rtw88: fix sparse warnings for download firmware routine

Patch
diff mbox series

diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
index 645207a01525..6969379ba37e 100644
--- a/drivers/net/wireless/realtek/rtw88/mac.c
+++ b/drivers/net/wireless/realtek/rtw88/mac.c
@@ -696,7 +696,8 @@  static void download_firmware_end_flow(struct rtw_dev *rtwdev)
 	rtw_write16(rtwdev, REG_MCUFW_CTRL, fw_ctrl);
 }
 
-int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware(struct rtw_dev *rtwdev,
+				   struct rtw_fw_state *fw)
 {
 	struct rtw_backup_info bckp[DLFW_RESTORE_REG_NUM];
 	const u8 *data = fw->firmware->data;
@@ -860,7 +861,8 @@  static int download_firmware_validate_legacy(struct rtw_dev *rtwdev)
 	return -EINVAL;
 }
 
-int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev,
+					  struct rtw_fw_state *fw)
 {
 	int ret = 0;