| Message ID | 20200426094115.23294-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fb1a9fc550cf748ba1225d734539ae97b5699b02 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: use true,false for bool variable in rtl_init_rfkill() | expand |
Jason Yan <yanaijie@huawei.com> wrote: > The 'blocked' is a bool variable, and '==' expression itself is bool > too. So no need to convert it to 0/1. > > This fixes the following coccicheck warning: > > drivers/net/wireless/realtek/rtlwifi/base.c:508:13-41: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Patch applied to wireless-drivers-next.git, thanks. fb1a9fc550cf rtlwifi: use true,false for bool variable in rtl_init_rfkill()
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c index c75192c4447f..a4489b9302d4 100644 --- a/drivers/net/wireless/realtek/rtlwifi/base.c +++ b/drivers/net/wireless/realtek/rtlwifi/base.c @@ -505,7 +505,7 @@ void rtl_init_rfkill(struct ieee80211_hw *hw) rtlpriv->rfkill.rfkill_state = radio_state; - blocked = (rtlpriv->rfkill.rfkill_state == 1) ? 0 : 1; + blocked = rtlpriv->rfkill.rfkill_state != 1; wiphy_rfkill_set_hw_state(hw->wiphy, blocked); }
The 'blocked' is a bool variable, and '==' expression itself is bool too. So no need to convert it to 0/1. This fixes the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/base.c:508:13-41: WARNING: Comparison of 0/1 to bool variable Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)