[v4] arm64: dts: meson: S922X: extend cpu opp-points
diff mbox series

Message ID 20200426162119.GA23268@imac
State Mainlined
Commit 75800d701782e89eecaf712fa141082b6e36f956
Headers show
Series
  • [v4] arm64: dts: meson: S922X: extend cpu opp-points
Related show

Commit Message

Tim Lewis April 26, 2020, 4:21 p.m. UTC
Add extra cpu pop points to allow mild overclock on S922X. The opp
points are found in Hardkernel N2 sources [1] and testing shows no
obvious issues on other S922X devices. Thermal throttling should
keep things in-check if needed.

[1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Tim Lewis <elatllat@gmail.com>

---
 arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
 1 files changed, 15 insertions(+)

Comments

Jerome Brunet April 27, 2020, 9:06 a.m. UTC | #1
On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:

> Add extra cpu pop points to allow mild overclock on S922X. The opp
> points are found in Hardkernel N2 sources [1] and testing shows no
> obvious issues on other S922X devices. Thermal throttling should
> keep things in-check if needed.

The Odroid-N2 has a massive heatsink mounted.
Do we have any idea if this applies (is safe) on any other S922x
device ?

It would be nice to get some input (review) from Amlogic is this to
included for any devices using the SoC.

In the meantime, I think this should be applied to odroid-n2 dt only.

>
> [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Tim Lewis <elatllat@gmail.com>
>
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
>  1 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> index 046cc332d..1e5d0ee5d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> @@ -65,6 +65,11 @@
>  			opp-hz = /bits/ 64 <1896000000>;
>  			opp-microvolt = <981000>;
>  		};
> +
> +		opp-1992000000 {
> +			opp-hz = /bits/ 64 <1992000000>;
> +			opp-microvolt = <1001000>;
> +		};
>  	};
>  
>  	cpub_opp_table_1: opp-table-1 {
> @@ -120,5 +125,15 @@
>  			opp-hz = /bits/ 64 <1704000000>;
>  			opp-microvolt = <891000>;
>  		};
> +
> +		opp-1800000000 {
> +			opp-hz = /bits/ 64 <1800000000>;
> +			opp-microvolt = <981000>;
> +		};
> +
> +		opp-1908000000 {
> +			opp-hz = /bits/ 64 <1908000000>;
> +			opp-microvolt = <1022000>;
> +		};
>  	};
>  };
Christian Hewitt April 27, 2020, 9:19 a.m. UTC | #2
> On 27 Apr 2020, at 1:06 pm, Jerome Brunet <jbrunet@baylibre.com> wrote:
> 
> On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
> 
>> Add extra cpu pop points to allow mild overclock on S922X. The opp
>> points are found in Hardkernel N2 sources [1] and testing shows no
>> obvious issues on other S922X devices. Thermal throttling should
>> keep things in-check if needed.
> 
> The Odroid-N2 has a massive heatsink mounted.
> Do we have any idea if this applies (is safe) on any other S922x
> device ?

I’ve tested it on several S922X box devices that I have, and also the
original S922X version of the VIM3 - all have similar sized passive
heatsinks about 20% the size of the N2 one. No obvious issues with
Kodi software decoding to increase CPU usage. NB: The original patch
submission was N2 specific and then reworked to apply to all S922X
devices at Neil’s suggestion (after my TB and earlier comments).

CH.

[snip]
Kevin Hilman April 29, 2020, 6:54 p.m. UTC | #3
Christian Hewitt <christianshewitt@gmail.com> writes:

>> On 27 Apr 2020, at 1:06 pm, Jerome Brunet <jbrunet@baylibre.com> wrote:
>> 
>> On Sun 26 Apr 2020 at 18:21, Tim Lewis <elatllat@gmail.com> wrote:
>> 
>>> Add extra cpu pop points to allow mild overclock on S922X. The opp
>>> points are found in Hardkernel N2 sources [1] and testing shows no
>>> obvious issues on other S922X devices. Thermal throttling should
>>> keep things in-check if needed.
>> 
>> The Odroid-N2 has a massive heatsink mounted.
>> Do we have any idea if this applies (is safe) on any other S922x
>> device ?
>
> I’ve tested it on several S922X box devices that I have, and also the
> original S922X version of the VIM3 - all have similar sized passive
> heatsinks about 20% the size of the N2 one. No obvious issues with
> Kodi software decoding to increase CPU usage. NB: The original patch
> submission was N2 specific and then reworked to apply to all S922X
> devices at Neil’s suggestion (after my TB and earlier comments).

Yes, we also have OPP lowering enabled by default (which I think Neil
mentioned earlier) so this should be safe (enough) to apply.

Queuing for v5.8,

Kevin
patchwork-bot+linux-amlogic@kernel.org April 29, 2020, 7:41 p.m. UTC | #4
Hello:

This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

On Sun, 26 Apr 2020 12:21:19 -0400 you wrote:
> Add extra cpu pop points to allow mild overclock on S922X. The opp
> points are found in Hardkernel N2 sources [1] and testing shows no
> obvious issues on other S922X devices. Thermal throttling should
> keep things in-check if needed.
> 
> [1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Tim Lewis <elatllat@gmail.com>
> 
> [...]


Here is a summary with links:
  - [v4] arm64: dts: meson: S922X: extend cpu opp-points
    https://git.kernel.org/khilman/linux-amlogic/c/75800d701782e89eecaf712fa141082b6e36f956

You are awesome, thank you!

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
index 046cc332d..1e5d0ee5d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
@@ -65,6 +65,11 @@ 
 			opp-hz = /bits/ 64 <1896000000>;
 			opp-microvolt = <981000>;
 		};
+
+		opp-1992000000 {
+			opp-hz = /bits/ 64 <1992000000>;
+			opp-microvolt = <1001000>;
+		};
 	};
 
 	cpub_opp_table_1: opp-table-1 {
@@ -120,5 +125,15 @@ 
 			opp-hz = /bits/ 64 <1704000000>;
 			opp-microvolt = <891000>;
 		};
+
+		opp-1800000000 {
+			opp-hz = /bits/ 64 <1800000000>;
+			opp-microvolt = <981000>;
+		};
+
+		opp-1908000000 {
+			opp-hz = /bits/ 64 <1908000000>;
+			opp-microvolt = <1022000>;
+		};
 	};
 };