| Message ID | 20200427150823.15350-2-bstroesser@ts.fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9299941716a3082e5335fe751ce433cdb62b26d0 |
| Headers | show |
| Series | target: tcmu: allow flexible pr and alua handling | expand |
On Mon, 27 Apr 2020 17:08:20 +0200, Bodo Stroesser wrote: > In commit b49d6f7885306ee636d5c1af52170f3069ccf5f7 the new attribute > emulate_pr was added. > passthrough_parse_cdb() uses the attribute's value to distinguish, > whether reservation commands should be rejected or not. > But the new attribute was not added to passthrough_attrib_attrs, so in > pscsi and tcmu - the users of passthrough_parse_cdb() - the attribute > is not available to change parser's behavior. Applied to 5.8/scsi-queue, thanks! [1/4] scsi: target: Add missing emulate_pr attribute to passthrough backends https://git.kernel.org/mkp/scsi/c/9299941716a3 [2/4] scsi: target: tcmu: Add attributes enforce_pr_isids and force_pr_aptpl https://git.kernel.org/mkp/scsi/c/4703b6252b33 [3/4] scsi: target: Make transport_flags per device https://git.kernel.org/mkp/scsi/c/69088a049488 [4/4] scsi: target: tcmu: Make pgr_support and alua_support attributes writable https://git.kernel.org/mkp/scsi/c/356ba2a8bc8d
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index ff82b21fdcce..d8589bb39c53 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -1203,6 +1203,7 @@ struct configfs_attribute *passthrough_attrib_attrs[] = { &attr_hw_block_size, &attr_hw_max_sectors, &attr_hw_queue_depth, + &attr_emulate_pr, &attr_alua_support, &attr_pgr_support, NULL,
In commit b49d6f7885306ee636d5c1af52170f3069ccf5f7 the new attribute emulate_pr was added. passthrough_parse_cdb() uses the attribute's value to distinguish, whether reservation commands should be rejected or not. But the new attribute was not added to passthrough_attrib_attrs, so in pscsi and tcmu - the users of passthrough_parse_cdb() - the attribute is not available to change parser's behavior. Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com> --- drivers/target/target_core_configfs.c | 1 + 1 file changed, 1 insertion(+)