| Message ID | 20200428015456.1194-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] blk-mq-debugfs: update blk_queue_flag_name[] accordingly for new flags | expand |
ping ? On 2020/4/28 9:54, Hou Tao wrote: > Else there may be magic numbers in /sys/kernel/debug/block/*/state. > > Signed-off-by: Hou Tao <houtao1@huawei.com> > Reviewed-by: Bart Van Assche <bvanassche@acm.org> > --- > v2: comments update as suggested by Bart > --- > block/blk-mq-debugfs.c | 3 +++ > include/linux/blkdev.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c > index 7a79db81a63f..49fdbc8a025f 100644 > --- a/block/blk-mq-debugfs.c > +++ b/block/blk-mq-debugfs.c > @@ -125,6 +125,9 @@ static const char *const blk_queue_flag_name[] = { > QUEUE_FLAG_NAME(REGISTERED), > QUEUE_FLAG_NAME(SCSI_PASSTHROUGH), > QUEUE_FLAG_NAME(QUIESCED), > + QUEUE_FLAG_NAME(PCI_P2PDMA), > + QUEUE_FLAG_NAME(ZONE_RESETALL), > + QUEUE_FLAG_NAME(RQ_ALLOC_TIME), > }; > #undef QUEUE_FLAG_NAME > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 32868fbedc9e..02809e4dd661 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -585,6 +585,7 @@ struct request_queue { > u64 write_hints[BLK_MAX_WRITE_HINTS]; > }; > > +/* Keep blk_queue_flag_name[] in sync with the definitions below */ > #define QUEUE_FLAG_STOPPED 0 /* queue is stopped */ > #define QUEUE_FLAG_DYING 1 /* queue being torn down */ > #define QUEUE_FLAG_NOMERGES 3 /* disable merge attempts */ >
ping again ? On 2020/5/25 14:32, Hou Tao wrote: > ping ? > > On 2020/4/28 9:54, Hou Tao wrote: >> Else there may be magic numbers in /sys/kernel/debug/block/*/state. >> >> Signed-off-by: Hou Tao <houtao1@huawei.com> >> Reviewed-by: Bart Van Assche <bvanassche@acm.org> >> --- >> v2: comments update as suggested by Bart >> --- >> block/blk-mq-debugfs.c | 3 +++ >> include/linux/blkdev.h | 1 + >> 2 files changed, 4 insertions(+) >> >> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c >> index 7a79db81a63f..49fdbc8a025f 100644 >> --- a/block/blk-mq-debugfs.c >> +++ b/block/blk-mq-debugfs.c >> @@ -125,6 +125,9 @@ static const char *const blk_queue_flag_name[] = { >> QUEUE_FLAG_NAME(REGISTERED), >> QUEUE_FLAG_NAME(SCSI_PASSTHROUGH), >> QUEUE_FLAG_NAME(QUIESCED), >> + QUEUE_FLAG_NAME(PCI_P2PDMA), >> + QUEUE_FLAG_NAME(ZONE_RESETALL), >> + QUEUE_FLAG_NAME(RQ_ALLOC_TIME), >> }; >> #undef QUEUE_FLAG_NAME >> >> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h >> index 32868fbedc9e..02809e4dd661 100644 >> --- a/include/linux/blkdev.h >> +++ b/include/linux/blkdev.h >> @@ -585,6 +585,7 @@ struct request_queue { >> u64 write_hints[BLK_MAX_WRITE_HINTS]; >> }; >> >> +/* Keep blk_queue_flag_name[] in sync with the definitions below */ >> #define QUEUE_FLAG_STOPPED 0 /* queue is stopped */ >> #define QUEUE_FLAG_DYING 1 /* queue being torn down */ >> #define QUEUE_FLAG_NOMERGES 3 /* disable merge attempts */ >> > > > . >
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 7a79db81a63f..49fdbc8a025f 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -125,6 +125,9 @@ static const char *const blk_queue_flag_name[] = { QUEUE_FLAG_NAME(REGISTERED), QUEUE_FLAG_NAME(SCSI_PASSTHROUGH), QUEUE_FLAG_NAME(QUIESCED), + QUEUE_FLAG_NAME(PCI_P2PDMA), + QUEUE_FLAG_NAME(ZONE_RESETALL), + QUEUE_FLAG_NAME(RQ_ALLOC_TIME), }; #undef QUEUE_FLAG_NAME diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 32868fbedc9e..02809e4dd661 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -585,6 +585,7 @@ struct request_queue { u64 write_hints[BLK_MAX_WRITE_HINTS]; }; +/* Keep blk_queue_flag_name[] in sync with the definitions below */ #define QUEUE_FLAG_STOPPED 0 /* queue is stopped */ #define QUEUE_FLAG_DYING 1 /* queue being torn down */ #define QUEUE_FLAG_NOMERGES 3 /* disable merge attempts */