| Message ID | 20200428213138.3171708-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume __maybe_unused | expand |
Hi Arnd, On 28/4/20 23:31, Arnd Bergmann wrote: > With the new static annotation, the compiler warns when the functions > are actually unused: > Right, thank you for the patch. > drivers/gpu/drm/rockchip/cdn-dp-core.c:1123:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function] > 1123 | static int cdn_dp_resume(struct device *dev) > | ^~~~~~~~~~~~~ > > Mark them __maybe_unused to suppress that warning as well. > > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c > index c634b95b50f7..1cde98c6b0e6 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c > @@ -1106,7 +1106,7 @@ static const struct component_ops cdn_dp_component_ops = { > .unbind = cdn_dp_unbind, > }; > > -static int cdn_dp_suspend(struct device *dev) > +static __maybe_unused int cdn_dp_suspend(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > int ret = 0; > @@ -1120,7 +1120,7 @@ static int cdn_dp_suspend(struct device *dev) > return ret; > } > > -static int cdn_dp_resume(struct device *dev) > +static __maybe_unused int cdn_dp_resume(struct device *dev) > { > struct cdn_dp_device *dp = dev_get_drvdata(dev); > >
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index c634b95b50f7..1cde98c6b0e6 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -1106,7 +1106,7 @@ static const struct component_ops cdn_dp_component_ops = { .unbind = cdn_dp_unbind, }; -static int cdn_dp_suspend(struct device *dev) +static __maybe_unused int cdn_dp_suspend(struct device *dev) { struct cdn_dp_device *dp = dev_get_drvdata(dev); int ret = 0; @@ -1120,7 +1120,7 @@ static int cdn_dp_suspend(struct device *dev) return ret; } -static int cdn_dp_resume(struct device *dev) +static __maybe_unused int cdn_dp_resume(struct device *dev) { struct cdn_dp_device *dp = dev_get_drvdata(dev);
With the new static annotation, the compiler warns when the functions are actually unused: drivers/gpu/drm/rockchip/cdn-dp-core.c:1123:12: error: 'cdn_dp_resume' defined but not used [-Werror=unused-function] 1123 | static int cdn_dp_resume(struct device *dev) | ^~~~~~~~~~~~~ Mark them __maybe_unused to suppress that warning as well. Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)