| Message ID | 20200429104234.18910-3-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes | expand |
On Wed, Apr 29, 2020 at 01:42:34PM +0300, Tomi Valkeinen wrote: > struct platform_driver panel_driver is only used from tilcdc_panel.c, so > it can be static. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index f66e2f2a1a35..cdc93a81b552 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -404,7 +404,7 @@ static const struct of_device_id panel_of_match[] = { > { }, > }; > > -struct platform_driver panel_driver = { > +static struct platform_driver panel_driver = { > .probe = panel_probe, > .remove = panel_remove, > .driver = { > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 29/04/2020 13:42, Tomi Valkeinen wrote: > struct platform_driver panel_driver is only used from tilcdc_panel.c, so > it can be static. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Jyri Sarha <jsarha@ti.com> > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index f66e2f2a1a35..cdc93a81b552 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -404,7 +404,7 @@ static const struct of_device_id panel_of_match[] = { > { }, > }; > > -struct platform_driver panel_driver = { > +static struct platform_driver panel_driver = { > .probe = panel_probe, > .remove = panel_remove, > .driver = { >
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c index f66e2f2a1a35..cdc93a81b552 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c @@ -404,7 +404,7 @@ static const struct of_device_id panel_of_match[] = { { }, }; -struct platform_driver panel_driver = { +static struct platform_driver panel_driver = { .probe = panel_probe, .remove = panel_remove, .driver = {
struct platform_driver panel_driver is only used from tilcdc_panel.c, so it can be static. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)