| Message ID | 20200429213901.16105-1-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/msr: Fix XEN_MSR_PAT to build with older binutils | expand |
On 29.04.2020 23:39, Andrew Cooper wrote: > Older binutils complains with: > trampoline.S:95: Error: junk `ul&0xffffffff' after expression > > Use an assembly-safe constant. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h index ea6e5497f4..8f6f5a97dd 100644 --- a/xen/include/asm-x86/processor.h +++ b/xen/include/asm-x86/processor.h @@ -99,7 +99,7 @@ * Host IA32_CR_PAT value to cover all memory types. This is not the default * MSR_PAT value, and is an ABI with PV guests. */ -#define XEN_MSR_PAT 0x050100070406ul +#define XEN_MSR_PAT _AC(0x050100070406, ULL) #ifndef __ASSEMBLY__
Older binutils complains with: trampoline.S:95: Error: junk `ul&0xffffffff' after expression Use an assembly-safe constant. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Wei Liu <wl@xen.org> CC: Roger Pau Monné <roger.pau@citrix.com> --- xen/include/asm-x86/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)