Message ID | 1f326612da05dfa74ebaaee6a852d5ef92a4ed29.1588347029.git.gitgitgadget@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Integrating line-log and changed-path Bloom filters | expand |
On Fri, May 01, 2020 at 03:30:25PM +0000, SZEDER Gábor via GitGitGadget wrote: > From: =?UTF-8?q?SZEDER=20G=C3=A1bor?= <szeder.dev@gmail.com> > > Remove the unused fields 'status', 'arg_alloc', 'arg_nr' and 'args' > from 'struct line_log_data'. They were already part of the struct > when it was introduced in commit 12da1d1f6 (Implement line-history > search (git log -L), 2013-03-28), but as far as I can tell none of > them have ever been actually used. > > Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > line-log.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/line-log.h b/line-log.h > index 8ee7a2bd4a1..882c5055bb8 100644 > --- a/line-log.h > +++ b/line-log.h > @@ -46,10 +46,7 @@ void sort_and_merge_range_set(struct range_set *); > struct line_log_data { > struct line_log_data *next; > char *path; > - char status; > struct range_set ranges; > - int arg_alloc, arg_nr; > - const char **args; > struct diff_filepair *pair; > struct diff_ranges diff; > }; > -- > gitgitgadget Very sensible. Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor
diff --git a/line-log.h b/line-log.h index 8ee7a2bd4a1..882c5055bb8 100644 --- a/line-log.h +++ b/line-log.h @@ -46,10 +46,7 @@ void sort_and_merge_range_set(struct range_set *); struct line_log_data { struct line_log_data *next; char *path; - char status; struct range_set ranges; - int arg_alloc, arg_nr; - const char **args; struct diff_filepair *pair; struct diff_ranges diff; };