[PULL,00/18] ppc-for-5.1 queue 20200507
mbox

Message ID 20200507050228.802395-1-david@gibson.dropbear.id.au
State New
Headers show

Pull-request

git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200507

Message

David Gibson May 7, 2020, 5:02 a.m. UTC
The following changes since commit 570a9214827e3d42f7173c4d4c9f045b99834cf0:

  Merge remote-tracking branch 'remotes/alistair/tags/pull-reg-to-apply-20200505' into staging (2020-05-06 15:38:02 +0100)

are available in the Git repository at:

  git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200507

for you to fetch changes up to c4f6a4a3dd5f2aa15329b8158de25f50b5ba3252:

  target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9 (2020-05-07 11:10:50 +1000)

----------------------------------------------------------------
ppc patch queue for 2020-04-07

First pull request for qemu-5.1.  This includes:
 * Removal of all remaining cases where we had CAS triggered reboots
 * A number of improvements to NMI injection
 * Support for partition scoped radix translation in softmmu
 * Some fixes for NVDIMM handling
 * A handful of other minor fixes

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      spapr/cas: Separate CAS handling from rebuilding the FDT

C├ędric Le Goater (6):
      target/ppc: Introduce a relocation bool in ppc_radix64_handle_mmu_fault()
      target/ppc: Assert if HV mode is set when running under a pseries machine
      target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation
      target/ppc: Extend ppc_radix64_check_prot() with a 'partition_scoped' bool
      target/ppc: Rework ppc_radix64_walk_tree() for partition-scoped translation
      target/ppc: Add support for Radix partition-scoped translation

Daniel Henrique Barboza (1):
      spapr_nvdimm.c: make 'label-size' mandatory

Daniele Buono (1):
      target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9

David Gibson (2):
      spapr: Don't allow unplug of NVLink2 devices
      spapr_nvdimm: Tweak error messages

Greg Kurz (3):
      spapr: Don't check capabilities removed between CAS calls
      spapr: Simplify selection of radix/hash during CAS
      spapr: Drop CAS reboot flag

Nicholas Piggin (3):
      target/ppc: Improve syscall exception logging
      ppc/spapr: tweak change system reset helper
      ppc/pnv: Add support for NMI interface

Suraj Jitindar Singh (1):
      target/ppc: Enforce that the root page directory size must be at least 5

 hw/ppc/pnv.c             |  29 +++
 hw/ppc/spapr.c           |  29 ++-
 hw/ppc/spapr_hcall.c     | 108 ++++++-----
 hw/ppc/spapr_nvdimm.c    |  10 +-
 hw/ppc/spapr_pci.c       |   4 +
 include/hw/ppc/spapr.h   |   8 +-
 target/ppc/cpu.h         |   5 +-
 target/ppc/excp_helper.c |  38 +++-
 target/ppc/mmu-radix64.c | 468 ++++++++++++++++++++++++++++++++++-------------
 target/ppc/translate.c   |  24 ++-
 10 files changed, 506 insertions(+), 217 deletions(-)

Comments

no-reply@patchew.org May 7, 2020, 6 a.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200507050228.802395-1-david@gibson.dropbear.id.au/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200507050228.802395-1-david@gibson.dropbear.id.au
Subject: [PULL 00/18] ppc-for-5.1 queue 20200507
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2d7cf2f target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9
8a40c99 spapr_nvdimm: Tweak error messages
c711884 spapr_nvdimm.c: make 'label-size' mandatory
3b966ed target/ppc: Add support for Radix partition-scoped translation
841c68d target/ppc: Rework ppc_radix64_walk_tree() for partition-scoped translation
a6648da target/ppc: Extend ppc_radix64_check_prot() with a 'partition_scoped' bool
ba64285 target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation
12ffc72 spapr: Don't allow unplug of NVLink2 devices
b807de2 target/ppc: Assert if HV mode is set when running under a pseries machine
b921172 target/ppc: Introduce a relocation bool in ppc_radix64_handle_mmu_fault()
0f1ea37 target/ppc: Enforce that the root page directory size must be at least 5
0265feb spapr: Drop CAS reboot flag
660bb29 spapr/cas: Separate CAS handling from rebuilding the FDT
ae65da6 spapr: Simplify selection of radix/hash during CAS
d9869ed ppc/pnv: Add support for NMI interface
f0ed65a ppc/spapr: tweak change system reset helper
d8a29c1 spapr: Don't check capabilities removed between CAS calls
a1a2597 target/ppc: Improve syscall exception logging

=== OUTPUT BEGIN ===
1/18 Checking commit a1a2597979cf (target/ppc: Improve syscall exception logging)
ERROR: code indent should never use tabs
#42: FILE: target/ppc/excp_helper.c:73:
+^I^I  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64$

ERROR: code indent should never use tabs
#43: FILE: target/ppc/excp_helper.c:74:
+^I^I  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64$

ERROR: code indent should never use tabs
#44: FILE: target/ppc/excp_helper.c:75:
+^I^I  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64$

ERROR: code indent should never use tabs
#47: FILE: target/ppc/excp_helper.c:78:
+^I^I  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),$

ERROR: code indent should never use tabs
#48: FILE: target/ppc/excp_helper.c:79:
+^I^I  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),$

ERROR: code indent should never use tabs
#49: FILE: target/ppc/excp_helper.c:80:
+^I^I  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),$

ERROR: code indent should never use tabs
#50: FILE: target/ppc/excp_helper.c:81:
+^I^I  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),$

ERROR: code indent should never use tabs
#51: FILE: target/ppc/excp_helper.c:82:
+^I^I  env->nip);$

total: 8 errors, 0 warnings, 47 lines checked

Patch 1/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/18 Checking commit d8a29c16840a (spapr: Don't check capabilities removed between CAS calls)
3/18 Checking commit f0ed65adc034 (ppc/spapr: tweak change system reset helper)
4/18 Checking commit d9869ed76eb9 (ppc/pnv: Add support for NMI interface)
5/18 Checking commit ae65da61eb6b (spapr: Simplify selection of radix/hash during CAS)
6/18 Checking commit 660bb297151b (spapr/cas: Separate CAS handling from rebuilding the FDT)
7/18 Checking commit 0265febed9dd (spapr: Drop CAS reboot flag)
8/18 Checking commit 0f1ea37bf8e0 (target/ppc: Enforce that the root page directory size must be at least 5)
9/18 Checking commit b92117299180 (target/ppc: Introduce a relocation bool in ppc_radix64_handle_mmu_fault())
10/18 Checking commit b807de27aab6 (target/ppc: Assert if HV mode is set when running under a pseries machine)
11/18 Checking commit 12ffc7216fdb (spapr: Don't allow unplug of NVLink2 devices)
12/18 Checking commit ba64285771b1 (target/ppc: Introduce ppc_radix64_xlate() for Radix tree translation)
13/18 Checking commit a6648da481a2 (target/ppc: Extend ppc_radix64_check_prot() with a 'partition_scoped' bool)
14/18 Checking commit 841c68de3923 (target/ppc: Rework ppc_radix64_walk_tree() for partition-scoped translation)
15/18 Checking commit 3b966ed8381d (target/ppc: Add support for Radix partition-scoped translation)
16/18 Checking commit c7118842415d (spapr_nvdimm.c: make 'label-size' mandatory)
17/18 Checking commit 8a40c9943f6e (spapr_nvdimm: Tweak error messages)
18/18 Checking commit 2d7cf2f3ab64 (target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200507050228.802395-1-david@gibson.dropbear.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell May 7, 2020, 1:29 p.m. UTC | #2
On Thu, 7 May 2020 at 06:04, David Gibson <david@gibson.dropbear.id.au> wrote:
>
> The following changes since commit 570a9214827e3d42f7173c4d4c9f045b99834cf0:
>
>   Merge remote-tracking branch 'remotes/alistair/tags/pull-reg-to-apply-20200505' into staging (2020-05-06 15:38:02 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200507
>
> for you to fetch changes up to c4f6a4a3dd5f2aa15329b8158de25f50b5ba3252:
>
>   target-ppc: fix rlwimi, rlwinm, rlwnm for Clang-9 (2020-05-07 11:10:50 +1000)
>
> ----------------------------------------------------------------
> ppc patch queue for 2020-04-07
>
> First pull request for qemu-5.1.  This includes:
>  * Removal of all remaining cases where we had CAS triggered reboots
>  * A number of improvements to NMI injection
>  * Support for partition scoped radix translation in softmmu
>  * Some fixes for NVDIMM handling
>  * A handful of other minor fixes
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM