| Message ID | 20200507070736.25418-1-zhengzengkai@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [-next] ACPI: debug: Make two functions static | expand |
On Thursday, May 7, 2020 9:07:36 AM CEST Zheng Zengkai wrote: > Fix sparse warnings: > > drivers/acpi/acpi_dbg.c:748:12: warning: > symbol 'acpi_aml_init' was not declared. Should it be static? > drivers/acpi/acpi_dbg.c:774:13: warning: > symbol 'acpi_aml_exit' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com> > --- > drivers/acpi/acpi_dbg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c > index 7a265c2171c0..6041974c7627 100644 > --- a/drivers/acpi/acpi_dbg.c > +++ b/drivers/acpi/acpi_dbg.c > @@ -745,7 +745,7 @@ static const struct acpi_debugger_ops acpi_aml_debugger = { > .notify_command_complete = acpi_aml_notify_command_complete, > }; > > -int __init acpi_aml_init(void) > +static int __init acpi_aml_init(void) > { > int ret; > > @@ -771,7 +771,7 @@ int __init acpi_aml_init(void) > return 0; > } > > -void __exit acpi_aml_exit(void) > +static void __exit acpi_aml_exit(void) > { > if (acpi_aml_initialized) { > acpi_unregister_debugger(&acpi_aml_debugger); > Applied as 5.8 material, thanks!
diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c index 7a265c2171c0..6041974c7627 100644 --- a/drivers/acpi/acpi_dbg.c +++ b/drivers/acpi/acpi_dbg.c @@ -745,7 +745,7 @@ static const struct acpi_debugger_ops acpi_aml_debugger = { .notify_command_complete = acpi_aml_notify_command_complete, }; -int __init acpi_aml_init(void) +static int __init acpi_aml_init(void) { int ret; @@ -771,7 +771,7 @@ int __init acpi_aml_init(void) return 0; } -void __exit acpi_aml_exit(void) +static void __exit acpi_aml_exit(void) { if (acpi_aml_initialized) { acpi_unregister_debugger(&acpi_aml_debugger);
Fix sparse warnings: drivers/acpi/acpi_dbg.c:748:12: warning: symbol 'acpi_aml_init' was not declared. Should it be static? drivers/acpi/acpi_dbg.c:774:13: warning: symbol 'acpi_aml_exit' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com> --- drivers/acpi/acpi_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)