diff mbox series

mm: memblock: fix minor typo and unclear comment

Message ID 1588846952-32166-1-git-send-email-qiwuchen55@gmail.com (mailing list archive)
State New, archived
Headers show
Series mm: memblock: fix minor typo and unclear comment | expand

Commit Message

chenqiwu May 7, 2020, 10:22 a.m. UTC 
From: chenqiwu <chenqiwu@xiaomi.com>

Fix a minor typo "usabe->usable" for the current discription
of member variable "memory" in struct memblock.

BTW, I think it's unclear the member variable "base" in
struct memblock_type is currently described as the physical
address of memory region, change it to base address of the
region is clearer since the variable is decorated as phys_addr_t.

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
 include/linux/memblock.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mike Rapoport May 9, 2020, 4:01 p.m. UTC | #1 
On Thu, May 07, 2020 at 06:22:32PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> Fix a minor typo "usabe->usable" for the current discription
> of member variable "memory" in struct memblock.
> 
> BTW, I think it's unclear the member variable "base" in
> struct memblock_type is currently described as the physical
> address of memory region, change it to base address of the
> region is clearer since the variable is decorated as phys_addr_t.
> 
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  include/linux/memblock.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 6bc37a7..b594e0b 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -41,7 +41,7 @@ enum memblock_flags {
>  
>  /**
>   * struct memblock_region - represents a memory region
> - * @base: physical address of the region
> + * @base: base address of the region
>   * @size: size of the region
>   * @flags: memory region attributes
>   * @nid: NUMA node id
> @@ -75,7 +75,7 @@ struct memblock_type {
>   * struct memblock - memblock allocator metadata
>   * @bottom_up: is bottom up direction?
>   * @current_limit: physical address of the current allocation limit
> - * @memory: usabe memory regions
> + * @memory: usable memory regions
>   * @reserved: reserved memory regions
>   * @physmem: all physical memory
>   */
> -- 
> 1.9.1
>
diff mbox series

Patch

diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 6bc37a7..b594e0b 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -41,7 +41,7 @@  enum memblock_flags {
 
 /**
  * struct memblock_region - represents a memory region
- * @base: physical address of the region
+ * @base: base address of the region
  * @size: size of the region
  * @flags: memory region attributes
  * @nid: NUMA node id
@@ -75,7 +75,7 @@  struct memblock_type {
  * struct memblock - memblock allocator metadata
  * @bottom_up: is bottom up direction?
  * @current_limit: physical address of the current allocation limit
- * @memory: usabe memory regions
+ * @memory: usable memory regions
  * @reserved: reserved memory regions
  * @physmem: all physical memory
  */