diff mbox series

[4/4] vmci_host: get rid of pointless access_ok()

Message ID	20200509234557.1124086-20-viro@ZenIV.linux.org.uk (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=MqLL=6X=vger.kernel.org=linux-fsdevel-owner@kernel.org> From: Al Viro <viro@ZenIV.linux.org.uk> To: linux-kernel@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, linux-fsdevel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [PATCH 4/4] vmci_host: get rid of pointless access_ok() Date: Sun, 10 May 2020 00:45:57 +0100 Message-Id: <20200509234557.1124086-20-viro@ZenIV.linux.org.uk> In-Reply-To: <20200509234557.1124086-1-viro@ZenIV.linux.org.uk> References: <20200509234124.GM23230@ZenIV.linux.org.uk> <20200509234557.1124086-1-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk
Series	[01/20] dlmfs_file_write(): get rid of pointless access_ok() \| expand [01/20] dlmfs_file_write(): get rid of pointless access_ok() [02/20] fat_dir_ioctl(): hadn't needed that access_ok() for more than a decade... [03/20] btrfs_ioctl_send(): don't bother with access_ok() [05/20] tomoyo_write_control(): get rid of pointless access_ok() [06/20] n_hdlc_tty_read(): remove pointless access_ok() [07/20] nvram: drop useless access_ok() [08/20] cm4000_cs.c cmm_ioctl(): get rid of pointless access_ok() [09/20] drivers/fpga/dfl-fme-pr.c: get rid of pointless access_ok() [10/20] drivers/fpga/dfl-afu-dma-region.c: get rid of pointless access_ok() [11/20] amifb: get rid of pointless access_ok() calls [12/20] omapfb: get rid of pointless access_ok() calls [13/20] drivers/crypto/ccp/sev-dev.c: get rid of pointless access_ok() [14/20] via-pmu: don't bother with access_ok() [15/20] drm_read(): get rid of pointless access_ok() [16/20] efi_test: get rid of pointless access_ok() [17/20] lpfc_debugfs: get rid of pointless access_ok() [18/20] usb: get rid of pointless access_ok() calls [19/20] hfi1: get rid of pointless access_ok() [4/4] vmci_host: get rid of pointless access_ok()

Commit Message

Al Viro May 9, 2020, 11:45 p.m. UTC

From: Al Viro <viro@zeniv.linux.org.uk>

get_user_pages_fast() doesn't need the caller to check that.
NB: reachable only from ioctl(2) and only under USER_DS

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/misc/vmw_vmci/vmci_host.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Greg Kroah-Hartman May 15, 2020, 10:53 a.m. UTC | #1

On Sun, May 10, 2020 at 12:45:57AM +0100, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> get_user_pages_fast() doesn't need the caller to check that.
> NB: reachable only from ioctl(2) and only under USER_DS
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  drivers/misc/vmw_vmci/vmci_host.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff mbox series

Patch

diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c
index ce16d6b99295..2d8328d928d5 100644
--- a/drivers/misc/vmw_vmci/vmci_host.c
+++ b/drivers/misc/vmw_vmci/vmci_host.c
@@ -233,8 +233,6 @@  static int vmci_host_setup_notify(struct vmci_ctx *context,
 	 * about the size.
 	 */
 	BUILD_BUG_ON(sizeof(bool) != sizeof(u8));
-	if (!access_ok((void __user *)uva, sizeof(u8)))
-		return VMCI_ERROR_GENERIC;
 
 	/*
 	 * Lock physical page backing a given user VA.